Add skeleton for Noto/Zeto domainapi tests #73

awrichar · 2024-08-08T21:16:52Z

Builds on #59, #67, #78, #83 to wire up basic Noto and Zeto contracts to the domainapi testbed.

Test infra

Starts an instance of the kata testbed and loads a domain into it. Relies on the Besu Docker from testinfra.

Noto

Loads a Noto domain implementation into the domainapi testbed
Exercises the domain by pushing JSON-RPC commands through the domainapi testbed
- Deploy bytecode for factory contract
- Initialize domain
- Use factory to deploy an instance of a Noto contract
- Invoke various "mint" and "transfer" methods of Noto

Includes two variants of Noto to illustrate domain customizability:

The normal "Noto" variant
- Any party can initiate a transfer
- Transaction sender provides an EIP-712 signature on the transaction inputs
- Notary verifies the signature, and notary submits all transactions to the base ledger
A variant called "NotoSelfSubmit"
- Any party can initiate a transfer
- Notary provides an EIP-712 signature on the assembled transaction
- Transaction sender submits the transaction to the base ledger themself (including the notary's signature)
- Base ledger verifies the notary signature

Zeto

Loads a Zeto domain implementation into the domainapi testbed
Exercises the domain by pushing JSON-RPC commands through the domainapi testbed
- Deploy bytecode for factory contract
- Initialize domain
- Use factory to deploy an instance of a Zeto contract
- Invoke "mint" method of Zeto
- Generate ZKPs and invoke "transfer" method of Zeto

Currently uses the zeto_anon contract only, as the simplest available example for Zeto.

awrichar · 2024-08-19T21:20:57Z

domains/noto/internal/noto/e2e_noto_test.go

+	// This should have been spent
+	// TODO: why does it still exist?
+	assert.Equal(t, int64(100), coins[0].Amount.Int64())
+	assert.Equal(t, notaryName, coins[0].Owner)


One of the more significant TODOs - I haven't figured out how to reliably test spending of coins.

yes 👍 - I've deferred this, and hopefully will have got back to it and sorted it for Pente before you're back from vacation

Finally closed the loop on this in #183

domains/noto/build.gradle

domains/noto/internal/noto/noto.go

Signed-off-by: Andrew Richardson <[email protected]>

peterbroadhurst · 2024-08-29T15:58:02Z

domains/noto/internal/noto/states.go

+	for {
+		// Simple oldest coin first algorithm
+		// TODO: make this configurable
+		// TODO: why is filters.QueryJSON not a public interface?


It certainly should be. I've done some work to try and make it more friendly than it was in the past.

It should be in toolkit_go (not kata)

This is in flight in #115 - I'll follow and integrate when ready.

peterbroadhurst · 2024-08-29T16:02:45Z

domains/noto/internal/noto/states.go

+	}, nil
+}
+
+func (n *Noto) prepareInputs(ctx context.Context, owner string, amount *ethtypes.HexInteger) ([]*NotoCoin, []*pb.StateRef, *big.Int, error) {


A bit of an aside - I think this is where the "domain configuration" really makes sense to have detailed options, vs. the on-chain configuration that's recorded into the smart contract.

How "I" do coin selection, is my configuration, for my node, on how I want to use my coins. Optimize for fewer coins, optimize for parallelism etc... that's my business. If I have different configuration to other nodes in the decentralized network, cool.

Whereas elsewhere in the Noto code right now, I see it (domain configuration) used more for the "how do I configure my off-chain stack, to correctly work with the on-chain instance of the smart contract". As I've gone through this PR, I'm feeling more and more convinced everything needed to know that should be baked into config (bit flags, strings, numbers, whatever) in the on-chain smart contract deployment event.

Proposal in code in #110 for Pente

peterbroadhurst · 2024-08-29T16:03:55Z

domains/noto/internal/noto/states.go

+
+func (n *Noto) prepareOutputs(owner string, amount *ethtypes.HexInteger) ([]*NotoCoin, []*pb.NewState, error) {
+	// Always produce a single coin for the entire output amount
+	// TODO: make this configurable


😄 - guess my above comment would have made more sense on this line

peterbroadhurst · 2024-08-29T16:30:11Z

domains/noto/testbed.config.yaml

Again need to get rid of all these copies of this

~~going to raise a specific issue for this~~

Realize I need to get further with Pente before I really have a strong enough opinion on what right looks like, to write it as an issue

kata/build.gradle

kata/pkg/testbed/testbed.go

Signed-off-by: Peter Broadhurst <[email protected]>

…into domainapi-noto Signed-off-by: Peter Broadhurst <[email protected]>

peterbroadhurst · 2024-08-29T17:14:44Z

solidity/contracts/interfaces/IPaladinContract.sol

@@ -18,6 +18,6 @@ interface IPaladinContract_V0 {

    // TODO: Reconcile if we need this standard function or not - or if domain off-chain code
    //       can simply construct the transactions directly
-    function paladinExecute_V0(bytes32 txId, bytes32 fnSelector, bytes calldata payload) external;
+    // function paladinExecute_V0(bytes32 txId, bytes32 fnSelector, bytes calldata payload) external;


We really need to come back to this as a group - hopefully before the end of next week

See #73 (comment)

peterbroadhurst · 2024-08-29T17:16:49Z

solidity/contracts/noto/Noto.sol

+            _unspent[outputs[i]] = true;
+        }
+
+        emit UTXOTransfer(inputs, outputs, data);


To your earlier point @awrichar we need to work through if this is a standardized thing, or a Domain responsibility.

I'm currently of the mind it's the former. However, as mentioned earlier that needs me to do more thinking in Pente.

See #73 (comment)

peterbroadhurst · 2024-08-29T17:22:00Z

solidity/contracts/noto/Noto.sol

+     * @param inputs Array of zero or more outputs of a previous function call against this
+     *      contract that have not yet been spent, and the signer is authorized to spend.
+     * @param outputs Array of zero or more new outputs to generate, for future transactions to spend.
+     * @param data Any additional transaction data (opaque to the blockchain)


I think we need to be clear on the importance of this field. The optimistic model for security is that the format of this data should be such, that anyone with a copy of the unmasked inputs/outputs and a copy of the Noto Go code for reference can validate:

Someone with authority to request this transaction (the "sender", but definitely not the msg.sender) has signed on the exact coins that will be spent, and the exact coins that will be produced

The notary (by submitting this transaction, or through this data field) provided an endorsement that the rules of the token were fully adhered to in the transaction

There is a special case (maybe some mint scenarios as demonstrated in the current state of Noto) where the "notary" and the "sender" roles might be signing using the same key, but I don't think that special case is something we need to optimize for as it's not the high throughput case (and it's a confusing case)

I've tweaked Noto slightly in #129 to include signature in more of the inputs and events - in order to satisfy "Someone with authority to request this transaction has signed on the exact coins that will be spent, and the exact coins that will be produced".

There's an unanswered question about how "standard" the spending events are across Paladin domains, and the split between specific things like signature vs a generic data payload. Need to come back to this in follow-ups.

Signed-off-by: Jim Zhang <[email protected]>

peterbroadhurst

This PR is a great step forwards @awrichar

I have made many comments, all of which I think are important for consideration as the work on Noto and Zeto continues.

I have spent much more time in Noto than Zeto, as @jimthematrix is actively working on the Zeto codebase on top of this branch, as is the specialist there.

I've also spent more time in the off-chain code, than the on-chain code - again deferring to @jimthematrix on the semantics, but there are a couple of architectural comments I've made on the relationship between the on-chain and off-chain.

None of my comments block the merging of this PR though, so definitely ✅ from me!

@jimthematrix is working on a build issue around circom to let this merge.

Signed-off-by: Jim Zhang <[email protected]>

Signed-off-by: Andrew Richardson <[email protected]>

Signed-off-by: Jim Zhang <[email protected]>

Add skeleton for Noto/Zeto domainapi tests

awrichar force-pushed the domainapi-noto branch from d8e0be2 to 6491fb9 Compare August 8, 2024 21:17

awrichar self-assigned this Aug 9, 2024

awrichar force-pushed the domainapi-noto branch 5 times, most recently from 7272a76 to 7d86e5a Compare August 14, 2024 17:43

awrichar mentioned this pull request Aug 14, 2024

Domain API V0 & Test Bed #59

Merged

awrichar force-pushed the domainapi-noto branch 2 times, most recently from 1d412f2 to bcf14e0 Compare August 16, 2024 20:40

Base automatically changed from domainapi to main August 16, 2024 20:44

awrichar force-pushed the domainapi-noto branch 10 times, most recently from 4c46096 to 2cca8ee Compare August 19, 2024 19:43

awrichar commented Aug 19, 2024

View reviewed changes

domains/noto/build.gradle Outdated Show resolved Hide resolved

awrichar commented Aug 19, 2024

View reviewed changes

domains/noto/internal/noto/noto.go Outdated Show resolved Hide resolved

awrichar force-pushed the domainapi-noto branch 2 times, most recently from 3f77f2d to 95118f6 Compare August 21, 2024 19:57

awrichar added 4 commits August 22, 2024 11:47

Add skeleton for Noto domainapi test

82336e1

Signed-off-by: Andrew Richardson <[email protected]>

Move gRPC listening logic into domain file

0937de0

Signed-off-by: Andrew Richardson <[email protected]>

Add replies and graceful close of gRPC client

8a4010c

Signed-off-by: Andrew Richardson <[email protected]>

Fix up logging

274f4b2

Signed-off-by: Andrew Richardson <[email protected]>

peterbroadhurst reviewed Aug 29, 2024

View reviewed changes

kata/build.gradle Outdated Show resolved Hide resolved

peterbroadhurst reviewed Aug 29, 2024

View reviewed changes

kata/pkg/testbed/testbed.go Show resolved Hide resolved

peterbroadhurst added 2 commits August 29, 2024 12:55

Use one loader

22bd5c3

Signed-off-by: Peter Broadhurst <[email protected]>

Merge branch 'domainapi-noto' of https://github.com/kaleido-io/paladin …

a01fcf8

…into domainapi-noto Signed-off-by: Peter Broadhurst <[email protected]>

peterbroadhurst reviewed Aug 29, 2024

View reviewed changes

Install circom for build

1810fb2

Signed-off-by: Jim Zhang <[email protected]>

peterbroadhurst approved these changes Aug 29, 2024

View reviewed changes

peterbroadhurst and others added 3 commits August 29, 2024 13:25

Merge branch 'main' into domainapi-noto

6fa44fb

Try a download type and using buildDir

e19b3cc

Signed-off-by: Jim Zhang <[email protected]>

Fix install of circom

1570d33

Signed-off-by: Andrew Richardson <[email protected]>

awrichar force-pushed the domainapi-noto branch from cdeb614 to 1570d33 Compare August 29, 2024 17:45

jimthematrix added 3 commits August 29, 2024 13:56

Revert zeto dependency to pre-upgradeable

e759e79

Signed-off-by: Jim Zhang <[email protected]>

Update to zeto dependency that uses local snarkjs

4b179fc

Signed-off-by: Jim Zhang <[email protected]>

Merge branch 'main' into domainapi-noto

256ac3d

jimthematrix merged commit 1d968ad into main Aug 29, 2024
2 checks passed

jimthematrix deleted the domainapi-noto branch August 29, 2024 18:56

This was referenced Sep 4, 2024

Pull in Zeto contracts to Solidity build #68

Closed

Noto enhancements and fixes #139

Merged

Basic PvP test between multiple domains #129

Merged

Zeto domain to support zeto tokens with anonymity and encryption #114

Merged

awrichar pushed a commit that referenced this pull request Sep 13, 2024

Merge pull request #73 from kaleido-io/domainapi-noto

3415e5f

Add skeleton for Noto/Zeto domainapi tests

peterbroadhurst mentioned this pull request Sep 16, 2024

Domain-specific signing logic #165

Open

awrichar mentioned this pull request Sep 26, 2024

Revisit the split for domain endorsement behavior #212

Open

jimthematrix unassigned awrichar Nov 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add skeleton for Noto/Zeto domainapi tests #73

Add skeleton for Noto/Zeto domainapi tests #73

awrichar commented Aug 8, 2024 •

edited

Loading

awrichar Aug 19, 2024

peterbroadhurst Aug 29, 2024

awrichar Sep 24, 2024

peterbroadhurst Aug 29, 2024

peterbroadhurst Aug 29, 2024

awrichar Sep 9, 2024

peterbroadhurst Aug 29, 2024 •

edited

Loading

peterbroadhurst Aug 31, 2024

peterbroadhurst Aug 29, 2024

peterbroadhurst Aug 29, 2024

peterbroadhurst Aug 29, 2024 •

edited

Loading

peterbroadhurst Aug 29, 2024

awrichar Sep 10, 2024

peterbroadhurst Aug 29, 2024

awrichar Sep 10, 2024

peterbroadhurst Aug 29, 2024

awrichar Sep 10, 2024

peterbroadhurst left a comment

Add skeleton for Noto/Zeto domainapi tests #73

Add skeleton for Noto/Zeto domainapi tests #73

Conversation

awrichar commented Aug 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

peterbroadhurst Aug 29, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

peterbroadhurst Aug 29, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

peterbroadhurst left a comment

Choose a reason for hiding this comment

awrichar commented Aug 8, 2024 •

edited

Loading

peterbroadhurst Aug 29, 2024 •

edited

Loading

peterbroadhurst Aug 29, 2024 •

edited

Loading