Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add caBundle for conversion webhook #23

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add caBundle for conversion webhook #23

wants to merge 4 commits into from

Conversation

Kuromesi
Copy link
Owner

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Special notes for reviews

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 48.44% and project coverage change: -0.18% ⚠️

Comparison is base (657c6d8) 43.34% compared to head (852e3d7) 43.16%.
Report is 1 commits behind head on master.

❗ Current head 852e3d7 differs from pull request most recent head 4631a0d. Consider uploading reports for the commit 4631a0d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   43.34%   43.16%   -0.18%     
==========================================
  Files          50       50              
  Lines        5373     5395      +22     
==========================================
  Hits         2329     2329              
- Misses       2647     2669      +22     
  Partials      397      397              
Flag Coverage Δ
unittests 43.16% <48.44%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...chrelease/control/canarystyle/deployment/canary.go 54.65% <ø> (ø)
...hrelease/control/canarystyle/deployment/control.go 74.35% <ø> (ø)
...chrelease/control/canarystyle/deployment/stable.go 56.66% <ø> (ø)
...release/control/partitionstyle/cloneset/control.go 74.69% <ø> (ø)
...elease/control/partitionstyle/daemonset/control.go 75.86% <ø> (ø)
...ease/control/partitionstyle/statefulset/control.go 81.81% <ø> (ø)
pkg/controller/batchrelease/control/util.go 79.41% <0.00%> (ø)
pkg/controller/deployment/controller.go 0.90% <0.00%> (ø)
pkg/controller/deployment/deployment_controller.go 26.41% <0.00%> (ø)
.../controller/deployment/deployment_event_handler.go 0.00% <0.00%> (ø)
... and 29 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kuromesi <[email protected]>
Signed-off-by: Kuromesi <[email protected]>
@Kuromesi Kuromesi force-pushed the conversion branch 3 times, most recently from 6793f86 to 852e3d7 Compare August 31, 2023 02:11
Signed-off-by: Kuromesi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant