Updated actions and pre-commit versions

KulikDM · Feb 20, 2024 · f457468 · f457468
1 parent 668c90d
commit f457468
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/.github/workflows/python-package.yml b/.github/workflows/python-package.yml
@@ -23,7 +23,7 @@ jobs:
     steps:
     - uses: actions/checkout@v4
     - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v4
+      uses: actions/setup-python@v5
       with:
         python-version: ${{ matrix.python-version }}
     - name: Install dependencies
@@ -41,4 +41,4 @@ jobs:
       run: |
         pytest -vs --doctest-modules --cov-fail-under=90 --cov-branch --cov=pythresh --cov-report term-missing --pyargs pythresh --continue-on-collection-errors
     - name: Codecov
-      uses: codecov/codecov-action@v3
+      uses: codecov/codecov-action@v4
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -21,7 +21,7 @@ repos:
         name: Format docstrings
 
   - repo: https://github.com/asottile/pyupgrade
-    rev: v3.15.0
+    rev: v3.15.1
     hooks:
       - id: pyupgrade
         args: [--py38-plus]
@@ -42,7 +42,7 @@ repos:
         name: Sort imports
 
   - repo: https://github.com/charliermarsh/ruff-pre-commit
-    rev: v0.1.13
+    rev: v0.2.2
     hooks:
       - id: ruff
         args: [--exit-non-zero-on-fix, --fix, --line-length=180]

diff --git a/pythresh/thresholds/decomp.py b/pythresh/thresholds/decomp.py
@@ -70,8 +70,10 @@ class DECOMP(BaseThresholder):
     def __init__(self, method='PCA', random_state=1234):
 
         self.method = method
-        self.method_funcs = {'NMF': NMF(random_state=random_state),
-                             'PCA': PCA(random_state=random_state),
+        self.method_funcs = {'NMF': NMF(n_components=1,
+                                        random_state=random_state),
+                             'PCA': PCA(n_components=1,
+                                        random_state=random_state),
                              'GRP': GaussianRandomProjection(n_components=2,
                                                              random_state=random_state),
                              'SRP': SparseRandomProjection(n_components=3,