Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating ingress config #18

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Updating ingress config #18

merged 1 commit into from
Jan 13, 2024

Conversation

ArchitKhanna
Copy link
Contributor

  • Modified ingress template;
  • Added values to the Values.yaml;
  • Updated chart version;

@ArchitKhanna
Updating ingress config
62ed421 
- Modified ingress template;
- Added values to the Values.yaml;
- Updated chart version;
@ArchitKhanna
Copy link
Contributor Author

@vara-bonthu I tested these changes on my infra and the ingress works well. Made a few changes to the template which were giving issues during deployment. We should also drop support for K8s version 1.25 and below since they are deprecated. Separate MR for that though.

vara-bonthu
vara-bonthu approved these changes Jan 13, 2024
View reviewed changes
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArchitKhanna ! LGTM 🚀

@vara-bonthu vara-bonthu merged commit 8bbcd2c into KubedAI:main Jan 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vara-bonthu vara-bonthu vara-bonthu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArchitKhanna @vara-bonthu