Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert IPs returned in round-robin fashion in the multicluster test #534

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

averevki
Copy link
Contributor

DNS resolution in the nightly pipeline should now work the same as your local dns resolver. Therefore assert for round robin strategy should also work in nightlies

Closes #495

@averevki averevki added the enhancement Improvement to existing test label Sep 11, 2024
@averevki averevki self-assigned this Sep 11, 2024
Copy link
Contributor

@trepel trepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I would maybe try two Robin rounds but I am probably too suspicious and it is overkill.

    dns_ip1 = dns.resolver.resolve(hostname.hostname)[0].address
    dns_ip2 = dns.resolver.resolve(hostname.hostname)[0].address
    dns_ip3 = dns.resolver.resolve(hostname.hostname)[0].address
    dns_ip4 = dns.resolver.resolve(hostname.hostname)[0].address
    assert dns_ip1 != dns_ip2, "Simple routing strategy should return IPs in a round-robin fashion"
    assert dns_ip1 == dns_ip3
    assert dns_ip2 == dns_ip4

@averevki averevki merged commit 668f3a1 into Kuadrant:main Sep 12, 2024
3 checks passed
@averevki averevki deleted the assert-round-robin branch September 12, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test for basic load balancing (Round Robin) to multicluster tests
3 participants