-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add geo load-balancing tests #516
Conversation
cb4599e
to
aaf0c31
Compare
@averevki Could you please resolve the conflicts? It would make reviewing easier and you need to that anyway |
4b03286
to
a36136f
Compare
I don't understand the reasoning behind doing this refactoring to |
I am seeing |
We don't need this functionality for now. Right now, it's committing the same object on each cluster, and I need more flexibility in CR configuration on each cluster |
You may be using wrong DNS servers. Or you are running under the internal network, which blocks non-internal dns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried each test modified in this PR, all good. I tried to modify the geo label to ES and I tried to remove it completely, the geo loadbalancing test failed as expected then. Code looks good to me, my understanding of it is that instead of crafting a request from certain GEO (DE or AU) or looking at DNS records in AWS the test specifically asks DE and AU DNS nameserver to resolve the same hostname and validates that external IP of right Gateway is returned. Nice!
Only thing that confuses me a little is that if I tried to resolve the hostname in https://dnschecker.org/ it took a few minutes till at least one AU server started resolving to "AU" Gateway external IP. |
Signed-off-by: averevki <[email protected]>
Signed-off-by: averevki <[email protected]>
a36136f
to
7bb9e09
Compare
Changes
Tests
Closes #496, closes #515