-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm Charts #728
Helm Charts #728
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #728 +/- ##
==========================================
+ Coverage 80.20% 81.84% +1.63%
==========================================
Files 64 77 +13
Lines 4492 6206 +1714
==========================================
+ Hits 3603 5079 +1476
- Misses 600 768 +168
- Partials 289 359 +70
Flags with carried forward coverage won't be shown. Click here to find out more.
|
2bca31c
to
b86e8c3
Compare
Signed-off-by: dd di cesare <[email protected]>
Signed-off-by: dd di cesare <[email protected]>
* When a release is published, the `release-helm-chart` workflow will package the chart and upload it to the release page. Then sync with the kuadrant repo. For this is necessary to build the manifests and chart before the release. Running `make helm-build` with the require envs to be released * When a release is deleted, it will sync with the kuadrant repo Signed-off-by: dd di cesare <[email protected]>
b86e8c3
to
76166e3
Compare
@didierofrivia when I run I didn't see a target |
@ehearneRedHat oops, you're right, forgot to push latest changes :S |
Signed-off-by: dd di cesare <[email protected]>
@ehearneRedHat Give it another try, I've updated the description too. |
Thanks @didierofrivia ! Will do . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verification steps ran successfully.
The critique on the kuadrant-operator
folder isn't too major for me, but something I'm more so curious about. It could lead to an inception of kuadrant-operator
's ! 😸
LGTM but would still like to know about the workflow files before giving 👍 .
Signed-off-by: dd di cesare <[email protected]>
Signed-off-by: dd di cesare <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now that I understand /kuadrant-operator
and workflows, and why it can't be verified until merge for deploying release.
This PR introduces a way to manage a DNS Operator Helm Chart. This is not meant to replace the way we are building and delivering our manifests (Kustomize, OLM) but to provide an alternative (complementary) way of delivering the operator.
This early implementation uses Kustomize to create the chart template, instead of creating and maintaining new ones with Helm, to later customize the Helm only settings with its
values.yaml
NOTES
values.yaml
cert-manager
TODO
Verification Steps
You should see it installed:
Since this chart has dependencies (authorino-operator, limitador-operator and dns-operator) that in the main branch are pointing to non existing chart versions, we need to build a version of the kuadrant-operator chart with already built and deployed dependency versions. Steps 4 and 5 won't be needed when installing the released chart
0.9.0-alpha1
)OR
To verify, we will check deployments and CRDs from dependencies that should be installed.
Note: The
kuadrant-operator-controller-manager
is not ready because the image is not built (ImagePullBackOff
).This will uninstall the kuadrant operator and listed dependencies in Chart.yaml only.