Add tls #52
Add tls #52
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: R-Lawton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
R-Lawton
force-pushed
the
add-tls
branch
2 times, most recently
from
00043d1
to
3560d6b
Compare
Signed-off-by: R-Lawton <[email protected]>
Signed-off-by: R-Lawton <[email protected]>
R-Lawton
requested review from
jasonmadigan
and removed request for
maleck13
| }, | ||
| issuerRef: { | ||
| name: selectedCertIssuer, | ||
| kind: 'ClusterIssuer', |
There was a problem hiding this comment.
I think these can also use NS scoped Issuer's too?
There was a problem hiding this comment.
do you mean you can specify a NS for the issuer?
There was a problem hiding this comment.
No i mean cert-manager can use either a ClusterIssuer (cluster-scoped) or an Issuer (ns-scoped)
There was a problem hiding this comment.
oh i did not know there was two types makes sense ill change that
|
|
||
| <Title headingLevel="h1">{('Create TLS Policy')}</Title> | ||
| <p className='help-block co-m-pane__heading-help-text'> | ||
| <div> Targets Gateway API networking resources Gateways to provide tls for gateway listeners by managing the lifecycle of tls certificates using CertManager</div> |
There was a problem hiding this comment.
probably want to i18n this in the very excellently named locales/en/plugin__console-plugin-template.json
There was a problem hiding this comment.
yup forgot about i18n ill update all the relevant places
| <FormHelperText> | ||
| <HelperText> | ||
| <HelperTextItem> | ||
| Reference to a Kubernetes resource that the policy attaches to. To create an additional gateway got to |
| <FormHelperText> | ||
| <HelperText> | ||
| <HelperTextItem> | ||
| Reference to the issuer for the created certificate. To create an additional Issuer got to |
| import { History } from 'history'; | ||
|
|
||
| export function handleCancel (namespace: string, policyType:string ,data , history: History) { | ||
| history.push(`/k8s/all-namespaces/kuadrant.io~v1alpha1~TLSPolicy`) |
There was a problem hiding this comment.
| history.push(`/k8s/all-namespaces/kuadrant.io~v1alpha1~TLSPolicy`) | |
| history.push(`/k8s/all-namespaces/kuadrant.io~v1alpha1~TLSPolicy`) |
maybe something like
| history.push(`/k8s/all-namespaces/kuadrant.io~v1alpha1~TLSPolicy`) | |
| history.push(`/k8s/all-namespaces/kuadrant.io~v1alpha1~${policyType}`) |
guess we'd need an apiVersion too
There was a problem hiding this comment.
yes good point, i could got to the policies view we create instead so we don't need to worry about API version
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Form view of the create:
Yaml view of the create (schema no showing trying to figure out why)
Follow up: