Reorder and add descriptions of make targets #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
=======================================
Coverage 61.78% 61.78%
=======================================
Files 2 2
Lines 785 785
=======================================
Hits 485 485
Misses 249 249
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
guicassolato
commented
Sep 4, 2024
| $(MAKE) create-build-file | ||
| $(MAKE) set-authorino-default-image | ||
| $(MAKE) set-replaces-directive | ||
| $(MAKE) manifests bundle VERSION=$(VERSION) AUTHORINO_VERSION=$(AUTHORINO_VERSION) | ||
| $(MAKE) helm-build VERSION=$(VERSION) AUTHORINO_VERSION=$(AUTHORINO_VERSION) | ||
|
|
||
| # A comma-separated list of bundle images (e.g. make catalog-build BUNDLE_IMGS=example.com/operator-bundle:v0.1.0,example.com/operator-bundle:v0.2.0). | ||
| # These images MUST exist in a registry and be pull-able. | ||
| BUNDLE_IMGS ?= $(BUNDLE_IMG) |
There was a problem hiding this comment.
No longer used since #201.
guicassolato
commented
Sep 4, 2024
| @@ -3,6 +3,8 @@ SHELL = /bin/bash | |||
|
|
|||
| MKFILE_PATH := $(abspath $(lastword $(MAKEFILE_LIST))) | |||
|
|
|||
| PROJECT_DIR := $(shell dirname $(abspath $(lastword $(MAKEFILE_LIST)))) | |||
There was a problem hiding this comment.
Needs to be defined before the ##@ Tools section.
KevFan
reviewed
Sep 4, 2024
KevFan
reviewed
Sep 4, 2024
Signed-off-by: Guilherme Cassolato <[email protected]>
guicassolato
force-pushed
the
fix-makefile
branch
from
0343d17
to
f347864
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.