Merge pull request #172 from adam-cattermole/fix-tracing-tags

Kuadrant · Feb 15, 2024 · 03b4263 · 03b4263
2 parents b0796bc + 00db9df
commit 03b4263
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/controllers/authorino_controller.go b/controllers/authorino_controller.go
@@ -384,7 +384,7 @@ func (r *AuthorinoReconciler) buildAuthorinoArgs(authorino *api.Authorino) []str
 	if tracingServiceEndpoint := authorino.Spec.Tracing.Endpoint; tracingServiceEndpoint != "" {
 		args = append(args, fmt.Sprintf("--%s=%s", flagTracingServiceEndpoint, tracingServiceEndpoint))
 		for key, value := range authorino.Spec.Tracing.Tags {
-			args = append(args, fmt.Sprintf(`--%s="%s=%s"`, flagTracingServiceTag, key, value))
+			args = append(args, fmt.Sprintf(`--%s=%s=%s`, flagTracingServiceTag, key, value))
 		}
 		if authorino.Spec.Tracing.Insecure {
 			args = append(args, fmt.Sprintf(`--%s`, flagTracingServiceInsecure))

diff --git a/controllers/authorino_controller_test.go b/controllers/authorino_controller_test.go
@@ -352,7 +352,7 @@ func checkAuthorinoArgs(authorinoInstance *api.Authorino, args []string) {
 		case flagTracingServiceEndpoint:
 			Expect(value).Should(Equal(authorinoInstance.Spec.Tracing.Endpoint))
 		case flagTracingServiceTag:
-			kv := strings.Split(strings.TrimPrefix(strings.TrimSuffix(value, `"`), `"`), "=")
+			kv := strings.Split(value, "=")
 			Expect(len(kv)).Should(Equal(2))
 			Expect(kv[1]).Should(Equal(authorinoInstance.Spec.Tracing.Tags[kv[0]]))
 		case flagTracingServiceInsecure: