Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LinearSolvers] Add external lib for parallel Gauss-Seidel #12621

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[LinearSolvers] Add external lib for parallel Gauss-Seidel #12621

wants to merge 5 commits into from
+2,201 −1

Conversation

matekelemen
Copy link
Contributor

I'm adding an external library I wrote for Gauss-Seidel smoothing in parallel for systems with imbalanced topologies. For better or worse, it includes related functionalities such as graph coloring and reordering as decided in #12343.

The library will be used as a smoother of a multigrid preconditioner/solver for higher order elements.

Changes

  • add MCGS as an external library for LinearSolversApplication
  • adapt the LinearSolversApplication's CMakeLists to include the new library

@matekelemen matekelemen added C++ External library Parallel-SMP Shared memory parallelism with OpenMP or C++ Threads labels Aug 8, 2024
@matekelemen matekelemen requested review from a team as code owners August 8, 2024 12:14
@loumalouomega
Copy link
Member

Nice library. Okay from my side.

RiccardoRossi
RiccardoRossi reviewed Aug 8, 2024
View reviewed changes
Copy link
Member

@RiccardoRossi RiccardoRossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mit licensed right?

If so no issue in my side (although admittedly i did not review the code, so someone should take the time of domingo a revie

@matekelemen
Copy link
Contributor Author

This is mit licensed right?

If so no issue in my side (although admittedly i did not review the code, so someone should take the time of domingo a revie

I wrote it so I'm open to suggestions. In fact, I'd be grateful for some review/input/suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiccardoRossi RiccardoRossi RiccardoRossi left review comments

@sunethwarna sunethwarna Awaiting requested review from sunethwarna

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
C++ External library Parallel-SMP Shared memory parallelism with OpenMP or C++ Threads
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matekelemen @loumalouomega @RiccardoRossi