Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Initial search documentation #12461

Merged
merged 15 commits into from
Jun 20, 2024
Merged

Conversation

loumalouomega
Copy link
Member

@loumalouomega loumalouomega commented Jun 14, 2024

@loumalouomega loumalouomega requested a review from a team as a code owner June 14, 2024 08:41
@loumalouomega loumalouomega added Documentation FastPR This Pr is simple and / or has been already tested and the revision should be fast labels Jun 14, 2024
@loumalouomega loumalouomega requested review from roigcarlo and removed request for a team June 14, 2024 08:42
roigcarlo
roigcarlo previously approved these changes Jun 14, 2024
Copy link
Member

@sunethwarna sunethwarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loumalouomega nice :) Btw, we don't put png and other stuff in the Kratos repo, we put them in https://github.com/KratosMultiphysics/Documentation.

I had to block since the auto merge was enabled.

@loumalouomega
Copy link
Member Author

@loumalouomega nice :) Btw, we don't put png and other stuff in the Kratos repo, we put them in KratosMultiphysics/Documentation.

I had to block since the auto merge was enabled.

Done

@loumalouomega
Copy link
Member Author

@roigcarlo do you knwo how to fix the doc build?

@roigcarlo
Copy link
Member

Mm its complains about reaching the max depth on the nav menus, for that we need to change how the whole menu works, so would tell you to put everything one level above and create a new section in the top menu.

For what I can read, the search is big enough to have its own section in the top nav.

@sunethwarna
Copy link
Member

sunethwarna commented Jun 14, 2024

Max menu depth is a limitation from the theme we are using. So as @roigcarlo said, you have put these one level up.

sunethwarna
sunethwarna previously approved these changes Jun 14, 2024
@sunethwarna
Copy link
Member

@loumalouomega It still does not show the images :/

@loumalouomega
Copy link
Member Author

@loumalouomega It still does not show the images :/

The menu appears empty

@loumalouomega
Copy link
Member Author

..................

@loumalouomega It still does not show the images :/

image

Yes, it does

@loumalouomega
Copy link
Member Author

..................

@loumalouomega It still does not show the images :/

The menu appears empty

I refactor, let's see if works

@loumalouomega
Copy link
Member Author

..................

@loumalouomega It still does not show the images :/

The menu appears empty

I refactor, let's see if works

It works, can we merge?

@loumalouomega
Copy link
Member Author

Hello? @sunethwarna

@loumalouomega
Copy link
Member Author

@roigcarlo

@roigcarlo
Copy link
Member

To me looks good, but @sunethwarna has to lift the block

Copy link
Member

@sunethwarna sunethwarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor

Co-authored-by: Suneth Warnakulasuriya <[email protected]>
@loumalouomega
Copy link
Member Author

minor

Done

Copy link
Member

@sunethwarna sunethwarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loumalouomega loumalouomega merged commit c6cfb31 into master Jun 20, 2024
13 checks passed
@loumalouomega loumalouomega deleted the doc/initial-search-doc branch June 20, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation FastPR This Pr is simple and / or has been already tested and the revision should be fast
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants