Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Exp] Add Log Expression #12448

Merged
merged 11 commits into from
Jun 13, 2024
Merged

[Exp] Add Log Expression #12448

merged 11 commits into from
Jun 13, 2024

Conversation

sunethwarna
Copy link
Member

@sunethwarna sunethwarna commented Jun 12, 2024 •
edited
Loading

📝 Description
This PR removes UnaryAbsExpression and creates a more generic UnaryExpression which is able to get Abs and Log, and can be easily extended in future for other operators if required.

Finally I am also adding documentation in the same PR :)

🆕 Changelog

  • Removes UnaryAbsExpression
  • Adds UnaryExpression
  • Adds ExpressionUtils::Log
  • Adds tests
  • Adds documentation

@sunethwarna sunethwarna self-assigned this Jun 12, 2024
@sunethwarna sunethwarna requested a review from a team as a code owner June 12, 2024 08:07
matekelemen
matekelemen reviewed Jun 12, 2024
View reviewed changes
kratos/expression/unary_expression.cpp Outdated

// template instantiations
template class UnaryExpression<UnaryOperations::Absolute>;
template class UnaryExpression<UnaryOperations::Logarithmic>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
template class UnaryExpression<UnaryOperations::Logarithmic>;
template class UnaryExpression<UnaryOperations::Logarithm>;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done :)

@sunethwarna sunethwarna mentioned this pull request Jun 13, 2024
Merged
@sunethwarna
Copy link
Member Author

ping @matekelemen

matekelemen
matekelemen approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@matekelemen matekelemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@sunethwarna sunethwarna merged commit a25b485 into master Jun 13, 2024
13 checks passed
@sunethwarna sunethwarna deleted the core/expression/feature/add_log_expression branch June 13, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matekelemen matekelemen matekelemen approved these changes

Assignees

@sunethwarna sunethwarna

Labels
C++ Feature Kratos Core Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunethwarna @matekelemen