[PfemFluid] CutFEM element #11868
Merged
[PfemFluid] CutFEM element #11868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Multiphysics/Kratos into PfemFluid/cut_fem_element
...ation/custom_elements/two_step_updated_lagrangian_V_P_implicit_fluid_FIC_cut_fem_element.cpp
Outdated
Show resolved
Hide resolved
...ation/custom_elements/two_step_updated_lagrangian_V_P_implicit_fluid_FIC_cut_fem_element.cpp
Outdated
Show resolved
Hide resolved
...ation/custom_elements/two_step_updated_lagrangian_V_P_implicit_fluid_FIC_cut_fem_element.cpp
Outdated
Show resolved
Hide resolved
...ation/custom_elements/two_step_updated_lagrangian_V_P_implicit_fluid_FIC_cut_fem_element.cpp
Outdated
Show resolved
Hide resolved
...ation/custom_elements/two_step_updated_lagrangian_V_P_implicit_fluid_FIC_cut_fem_element.cpp
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| bool longDamBreak = false; // to attivate in case of long dam breaks to avoid separeted elements in the water front | ||
| if (longDamBreak == true) |
There was a problem hiding this comment.
Suggested change
| if (longDamBreak == true) | |
| if (longDamBreak) |
There was a problem hiding this comment.
besides, the If will never be activated since we just defined this variable to false right?
| KRATOS_TRY | ||
| const SizeType dimension = mrModelPart.ElementsBegin()->GetGeometry().WorkingSpaceDimension(); | ||
|
|
||
| NodeWeakPtrVectorType &neighb_nodes = CheckedNode.GetValue(NEIGHBOUR_NODES); |
| // Project Name: KratosPfemFluidDynamicsApplication $ | ||
| // Created by: $Author: AFranci $ | ||
| // Last modified by: $Co-Author: $ | ||
| // Date: $Date: October 2016 $ |
There was a problem hiding this comment.
Suggested change
| // Date: $Date: October 2016 $ | |
| // Date: $Date: December 2023 $ |
| } | ||
| else | ||
| { | ||
| const double cosAngle01 = (nodesVelocities[0][0] * nodesVelocities[1][0] + nodesVelocities[0][1] * nodesVelocities[1][1] + nodesVelocities[0][1] * nodesVelocities[1][2]) / |
There was a problem hiding this comment.
This operation can be defined somewhere and then reused many times
...ations/PfemFluidDynamicsApplication/tests/cut_pfem_tests/dam_break_2d/ProjectParameters.json
Outdated
Show resolved
Hide resolved
|
I cleaned up all the stuff related to the element. About the process, I'd consider deriving from the standard one to avoid code duplication prior to any clean up. |
AlejandroCornejo
previously approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR adds a CutPFEM Navier-Stokes element together with its required functionalities.