feat: add search #287
Draft
feat: add search #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only parse from and to dates when searching toggle between date formats when searching refactoring change date formatting for searched events raise exception when search dates not given
|
Thanks! I'll be very busy this week, I'll take a look this weekend :) |
Deuchnord
requested changes
Oct 26, 2022
kosmorro/__main__.py
Outdated
| show_graph: bool, | ||
| ) -> dumper.Dumper: | ||
| try: | ||
| if search_from is None or search_to is None: |
There was a problem hiding this comment.
I'm realizing that if user doesn't provide the --from argument, we could assert that we want to search from the current date by default? What do you think?
There was a problem hiding this comment.
Yeah, that makes sense to me!
kosmorro/__main__.py
Outdated
| help=_("The date to begin searching for events."), | ||
| ) | ||
| parser.add_argument( | ||
| "--to", type=str, default=None, help=_("The date to end searching for events.") |
There was a problem hiding this comment.
If we make --from optional as proposed, then we should perhaps rename this argument to --until?
nicfb
force-pushed
the
feat/add-search
branch
from
16a9b29
to
16cbbb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
This PR makes use of the event searching capability added to Kosmorrolib in version 1.1. It will allow users to search for specific events in a given date range.
I don't think this is 100% complete yet, but I wanted to get your feedback on it.