Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): don't use up-to-date for PRs #6637

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Nov 7, 2024

What this PR does / why we need it:

Don't use up-to-date for PRs. This saves us checking out the full history of this repo on every CI run in PR checks which takes around 2 minutes now:

https://github.com/Kong/kubernetes-ingress-controller/actions/runs/11721257079/job/32649556019#step:2:53

Tested in https://github.com/pmalek/kubernetes-ingress-controller/actions/runs/11721938305/job/32650441822 (due to checks workflow using pull_request_target which runs the CI definition from base branch).

@pmalek pmalek added the area/ci label Nov 7, 2024
@pmalek pmalek self-assigned this Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.7%. Comparing base (9517268) to head (5eec77f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #6637     +/-   ##
=======================================
- Coverage   77.7%   77.7%   -0.1%     
=======================================
  Files        202     202             
  Lines      23758   23833     +75     
=======================================
+ Hits       18483   18523     +40     
- Misses      4335    4376     +41     
+ Partials     940     934      -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Nov 7, 2024
@pmalek pmalek force-pushed the no-up-to-date-for-prs branch 6 times, most recently from 7fd23b7 to 2610f03 Compare November 13, 2024 17:50
@pmalek pmalek marked this pull request as ready for review November 13, 2024 18:44
@pmalek pmalek requested a review from a team as a code owner November 13, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant