Publish nightly and release Docker images to public ECR #2465
+43
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arthur Diniz [email protected]
What this PR does / why we need it:
This PR adds the feature to push
nightly
andrelease
Docker images to AWS public ECR.Which issue this PR fixes: #2370
Special notes for your reviewer:
From the kong organization side, it's necessary to:
ACCESS_KEY_ID
andSECRET_ACCESS_KEY
to GitHub secrets asAWS_ECR_ACCESS_KEY_ID
andAWS_ECR_SECRET_ACCESS_KEY
variables.The IAM user needs to have a policy attached with permissions to the registry and to the specific repository. For this you can follow the official AWS documentation.
Example of policy I have used:
PR Readiness Checklist:
To validate this PR I have tested it inside my own AWS account and DockerHub:
GitHub actions job
ECR
Docker Hub
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR