fix: not sending form urlencoded properly in JS fetch snippets (#218)

Co-authored-by: Eric Reynolds <[email protected]>
Kong · Sep 3, 2021 · 6b85ba2 · 6b85ba2
1 parent 9530d5b
commit 6b85ba2
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/src/targets/javascript/fetch.js b/src/targets/javascript/fetch.js
@@ -67,7 +67,17 @@ module.exports = function (source, options) {
       }
   }
 
-  code.push('const options = %s;', stringifyObject(options, { indent: opts.indent, inlineCharacterLimit: 80 }))
+  code.push('const options = %s;', stringifyObject(options, {
+    indent: opts.indent,
+    inlineCharacterLimit: 80,
+    transform: (object, property, originalResult) => {
+      if (property === 'body' && source.postData.mimeType === 'application/x-www-form-urlencoded') {
+        return `new URLSearchParams(${originalResult})`
+      }
+
+      return originalResult
+    }
+  }))
     .blank()
 
   if (source.postData.mimeType === 'multipart/form-data') {

diff --git a/test/fixtures/output/javascript/fetch/application-form-encoded.js b/test/fixtures/output/javascript/fetch/application-form-encoded.js
@@ -1,7 +1,7 @@
 const options = {
   method: 'POST',
   headers: {'content-type': 'application/x-www-form-urlencoded'},
-  body: {foo: 'bar', hello: 'world'}
+  body: new URLSearchParams({foo: 'bar', hello: 'world'})
 };
 
 fetch('http://mockbin.com/har', options)

diff --git a/test/fixtures/output/javascript/fetch/full.js b/test/fixtures/output/javascript/fetch/full.js
@@ -5,7 +5,7 @@ const options = {
     accept: 'application/json',
     'content-type': 'application/x-www-form-urlencoded'
   },
-  body: {foo: 'bar'}
+  body: new URLSearchParams({foo: 'bar'})
 };
 
 fetch('http://mockbin.com/har?foo=bar&foo=baz&baz=abc&key=value', options)