tests: use DockerHub token in integration and e2e tests #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
force-pushed
the
use-dockerhub-token-in-integration-tests
branch
2 times, most recently
from
80f565b
to
973fffc
Compare
pmalek
force-pushed
the
use-dockerhub-token-in-integration-tests
branch
from
973fffc
to
8803e05
Compare
pmalek
force-pushed
the
use-dockerhub-token-in-integration-tests
branch
from
abdcd8d
to
c589386
Compare
pmalek
changed the title
programmer04
approved these changes
Aug 19, 2024
programmer04
approved these changes
Aug 19, 2024
|
Let's put this on hold. It is possible to use kind configuration instead of adding the imagePullSecrets config to specific Pods: https://kind.sigs.k8s.io/docs/user/private-registries/#add-credentials-to-the-nodes |
|
Likely to get superseded by the approach in #679 which is more scalable and less error prone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add dockerconfigjson
Secretcreation in integration and e2e tests.This is currently being controlled via envs:
DOCKERHUB_PULL_USERNAMEDOCKERHUB_PULL_TOKENRegistry is hardcoded to
https://index.docker.io/v1/Which issue this PR fixes
Part of #452