Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letterboxd filters additional detail #2255

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

Kevin2kkelly
Copy link
Contributor

Description

  • Clarified that the Letterboxd rating filter users a 10 point scale, not 100 (i.e. 40-100 would never capture anything, 1-40 would always capture everything)
  • Added an annotation to note filters which work with /USERNAME/films/reviews/ URLs

Type of Change

  • Documentation change (non-code changes affecting only the wiki)

Checklist

  • Updated Documentation to reflect changes

Test yml below and log attached.

collections: 

#### /USERNAME/films/reviews/ URLs
  Fennessey Reviews Control:
    letterboxd_list_details: 
      url: https://letterboxd.com/seanfennessey/films/reviews/
      limit: 60

  Fennessey Reviews Rating:
    letterboxd_list_details: 
      url: https://letterboxd.com/seanfennessey/films/reviews/
      limit: 60
      rating: 9-10

  Fennessey Reviews Year:
    letterboxd_list_details: 
      url: https://letterboxd.com/seanfennessey/films/reviews/
      limit: 60
      year: 2014-2015

#### Integer Test
  Fennessey Alice 9-10:
    letterboxd_list_details: 
      url: https://letterboxd.com/seanfennessey/list/movies-alice-has-seen/detail/
      limit: 60
      rating: 9-10

  Fennessey Alice 11-100:
    letterboxd_list_details: 
      url: https://letterboxd.com/seanfennessey/list/movies-alice-has-seen/detail/
      limit: 60
      rating: 11-100

  Fennessey Reviews 11-100:
    letterboxd_list_details: 
      url: https://letterboxd.com/seanfennessey/films/reviews/
      limit: 60
      rating: 11-100

meta.log

@meisnate12 meisnate12 merged commit 8d113a5 into Kometa-Team:nightly Oct 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants