Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issues with input_id being a list #2182

Closed
wants to merge 2 commits into from

Conversation

ricoloic
Copy link

@ricoloic ricoloic commented Jul 31, 2024

Fixing an issue when using MAL and/or anilist

Description

This change is to fix an issue that has been going on for about a month or so which seemed to have been cause to a list of ids being treated as a single id

| Traceback (most recent call last):                                                                 |
|   File "//kometa.py", line 812, in run_collection                                                  |
|     builder.filter_and_save_items(builder.gather_ids(method, value))                               |
|   File "/modules/builder.py", line 2298, in filter_and_save_items                                  |
|     input_id = int(input_id)                                                                       |
|                ^^^^^^^^^^^^^                                                                       |
| TypeError: int() argument must be a string, a bytes-like object or a real number, not 'list'       |
|                                                                                                    |
| Unknown Error: int() argument must be a string, a bytes-like object or a real number, not 'list'   |

#2135

Issues Fixed or Closed

  • Fixes #(2135)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation change (non-code changes affecting only the wiki)
  • [] Infrastructure change (changes related to the github repo, build process, or the like)

Checklist

Please delete options that are not relevant.

  • Updated the CHANGELOG with the changes

Fixing an issue when using MAL and/or anilist
@YozoraXCII
Copy link
Contributor

Can you rebase this against nightly instead of master please

@ricoloic
Copy link
Author

ricoloic commented Aug 1, 2024

Can you rebase this against nightly instead of master please

Sure will do

@ricoloic
Copy link
Author

ricoloic commented Aug 1, 2024

@YozoraXCII I opened a new PR (due to conflicts I created a new branch from nightly) and closing the PR, thanks

#2183

@ricoloic ricoloic closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants