alter_collection & sync_collection batch edits #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved alter_collections call and passed through items_added and items_removed so that batchEdits can be used in plex.py
Amended alter_collection to use batch edits for labels and collections
sysmoon14
changed the title
|
I have tested this locally (in combination with the Python-PlexAPI fix) and can confirm this functions as expected with no apparent negative impact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed
add_to_collectionandsync_collectionmethods inbuilder.pyto pass the parameters required for batchEdits toalter_collectioninplex.py.plex.pyhas also been updated to implement the batchEdit functionality from PythonPlexAPI.With the above changes I noticed dramatic improvements in the time taken to add 45 items to a movie collection which also had a custom sort.
19.1nightly27took 4:07 seconds, versus 31 seconds using the code from this PR.Note: PythonPlexAPI is currently broken for adding collections, and this PR will need to be released in order for my implementation to succeed.
Type of Change
Please delete options that are not relevant.
Checklist