Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to WinGet #455

Merged
merged 1 commit into from
Mar 4, 2023
Merged

Publish to WinGet #455

merged 1 commit into from
Mar 4, 2023

Conversation

vedantmgoyal9
Copy link
Contributor

@vedantmgoyal9 vedantmgoyal9 commented Mar 3, 2023

Copy link
Owner

@Klocman Klocman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This action won't work without the secret token, and the version extraction I believe won't work correctly either (the docs say that by default it grabs version from the tag so the custom code shouldn't be required). There's also no .exe filter to point at the installer.
Thank you for the PR, but it looks like I'll have to figure the whole process myself either way.

@vedantmgoyal9
Copy link
Contributor Author

You only have to create a GitHub Personal Access Token and store it as a repository secret.

The last two 0s are appended to the version because the installer writes 5.4.0.0 to Apps and Features entries in Control Panel and not 5.4. This is due to how the inno setup (.iss) installer is configured:

#define MyAppVersion "5.4.0.0"

AppVersion={#MyAppVersion}

Also, the action automatically filters .exe files from GitHub Release assets.

@Klocman
Copy link
Owner

Klocman commented Mar 4, 2023

Alright, I took a look at how the action and overall winget update process works, looks like this should work. I'll give it a try.

@Klocman Klocman merged commit 38ecaff into Klocman:master Mar 4, 2023
@Klocman
Copy link
Owner

Klocman commented Mar 5, 2023

The version extraction failed, so this release won't get automatically pushed to winget.
image
I fixed it here b3253f9 but it'll have to wait for the next release to be applied.

@NekoJonez NekoJonez mentioned this pull request Sep 30, 2023
@sitiom
Copy link
Contributor

sitiom commented Sep 1, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants