Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading kinto-admin to v2.1.0. Upgrading node version to 18. #3303

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

Copy link
Contributor

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexcottner alexcottner merged commit 2abfb2e into master Nov 21, 2023
16 checks passed
@alexcottner alexcottner deleted the admin-v2.1.0 branch November 21, 2023 17:46
@grahamalama
Copy link
Contributor

grahamalama commented Nov 21, 2023

I think if you just include the issue number in the list (without the markdown formatting), we'll get the title of the issue inline. i.e.
- #237

vs
- [#237](https://github.com/Kinto/kinto-admin/issues/237)

@alexcottner
Copy link
Contributor Author

I think if you just include the issue number in the list (without the markdown formatting), we'll get the title of the issue inline. i.e. - #237

* [Activate POST on collections #237](https://github.com/Kinto/kinto/issues/237)

vs - [#237](https://github.com/Kinto/kinto-admin/issues/237)

* [#237](https://github.com/Kinto/kinto-admin/issues/237)

That links it to issue 237 in the kinto repo and not the kinto-admin repo. I couldn't find another way to do it.

@grahamalama
Copy link
Contributor

🤦🏻‍♂️ my bad, got my repos mixed up, and that notation referring to this repo indeed makes sense.

I did just stumble on this though -- does this work in the description?

- https://github.com/Kinto/kinto-admin/issues/237

@alexcottner
Copy link
Contributor Author

Oh yeah that's way better.

alexcottner added a commit that referenced this pull request Nov 22, 2023
* Preparing release 16.2.2

* Updating How to Release section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants