Support configuration from bucket metadata (fixes #27) #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Natim
reviewed
Jan 27, 2017
| metadata = storage.get(parent_id=bucket_uri, | ||
| collection_id='collection', | ||
| object_id=collection_id) | ||
| if 'kinto-emailer' not in metadata: |
Natim
approved these changes
Jan 27, 2017
| emails = [r for r in recipients if not GROUP_REGEXP.match(r)] | ||
| groups = [r for r in recipients if GROUP_REGEXP.match(r)] | ||
| groups = [r.format(**context) for r in recipients |
There was a problem hiding this comment.
I think it worth having a comment saying that you might want to build the group name from the collection_id
There was a problem hiding this comment.
I added it in the merge commit
| @@ -161,7 +170,7 @@ def includeme(config): | |||
|
|
|||
| # Listen to collection modification before commit for validation. | |||
| config.add_subscriber(_validate_emailer_settings, ResourceChanged, | |||
| for_resources=('collection',), | |||
| for_resources=('bucket', 'collection',), | |||
| for_actions=('create', 'update')) | |||
|
|
|||
| # Listen to collection and record change events. | |||
There was a problem hiding this comment.
I guess we should probably support groups and buckets events for email notifications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27