-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature pipe captures #280
base: master
Are you sure you want to change the base?
Changes from 7 commits
f77aedd
2e84769
7461375
2549372
8c11c84
101afc9
dcb060a
53614a7
a72b47e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
from pyshark.capture.pipe_capture import PipeCapture | ||
from pyshark.capture.capture import TSharkCrashException, TSharkVersionException | ||
from pyshark.tshark.tshark import tshark_supports_json | ||
import asyncio | ||
import subprocess | ||
import tempfile | ||
|
||
|
||
class DisplayFilterNotAllowedException(Exception): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Due to how RingCaptures work, Tshark will not allow a display filter in this class. |
||
"""Display Filters are not allowed in PipeRingCapture.""" | ||
|
||
|
||
class PipeRingCapture(PipeCapture): | ||
""" | ||
Represents a live ringbuffer capture on a network interface. | ||
""" | ||
|
||
def __init__(self, pipe, ring_file_size=1024, num_ring_files=2, ring_file_name=None, | ||
only_summaries=False, decryption_key=None, | ||
encryption_type='wpa-pwk', decode_as=None, disable_protocol=None, | ||
tshark_path=None, override_prefs=None, include_raw=False, use_json=False, **kwargs): | ||
""" | ||
Creates a new live capturer on a given interface. Does not start the actual capture itself. | ||
:param ring_file_size: Size of the ring file in kB, default is 1024 | ||
:param num_ring_files: Number of ring files to keep, default is 1 | ||
:param ring_file_name: Name of the ring file, default is /tmp/pyshark.pcap | ||
:param interface: Name of the interface to sniff on or a list of names (str). If not given, runs on all interfaces. | ||
:param bpf_filter: BPF filter to use on packets. | ||
:param display_filter: Display (wireshark) filter to use. | ||
:param only_summaries: Only produce packet summaries, much faster but includes very little information | ||
:param decryption_key: Optional key used to encrypt and decrypt captured traffic. | ||
:param encryption_type: Standard of encryption used in captured traffic (must be either 'WEP', 'WPA-PWD', or | ||
'WPA-PWK'. Defaults to WPA-PWK). | ||
:param decode_as: A dictionary of {decode_criterion_string: decode_as_protocol} that are used to tell tshark | ||
to decode protocols in situations it wouldn't usually, for instance {'tcp.port==8888': 'http'} would make | ||
it attempt to decode any port 8888 traffic as HTTP. See tshark documentation for details. | ||
:param tshark_path: Path of the tshark binary | ||
:param override_prefs: A dictionary of tshark preferences to override, {PREFERENCE_NAME: PREFERENCE_VALUE, ...}. | ||
:param disable_protocol: Tells tshark to remove a dissector for a specifc protocol. | ||
""" | ||
if "display_filter" in kwargs.keys(): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can remove this as well as the exception. I don't think it's needed. Again, just write in the doc that display filters are not supported. If you feel strongly about having this exception, then it's better the previous way. This is bad because it "swallows" any kwargs the user may have inputted (say they misspelt use_json, it'll suddenly not fail but not work either) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. While I agree, I should pass them up to the super, I think it's important to do a hard exception for this since every other capture allows it. |
||
raise DisplayFilterNotAllowedException("Display Filters are not allowed in PipeRingCapture.") | ||
|
||
super(PipeRingCapture, self).__init__(pipe, display_filter=None, only_summaries=only_summaries, | ||
decryption_key=decryption_key, encryption_type=encryption_type, | ||
tshark_path=tshark_path, decode_as=decode_as, disable_protocol=disable_protocol, | ||
override_prefs=override_prefs, include_raw=include_raw, use_json=use_json) | ||
|
||
self.ring_file_size = ring_file_size | ||
self.num_ring_files = num_ring_files | ||
if ring_file_name is None: | ||
self.ring_file_name = tempfile.mktemp(suffix=".pcap", prefix="pyshark_") | ||
else: | ||
self.ring_file_name = ring_file_name | ||
|
||
def get_parameters(self, packet_count=None): | ||
""" | ||
Returns the special tshark parameters to be used according to the configuration of this class. | ||
""" | ||
params = super(PipeRingCapture, self).get_parameters()[:-2] | ||
params.extend(['-i', self._pipe]) | ||
params += ['-b', 'filesize:' + str(self.ring_file_size), '-b', 'files:' + str(self.num_ring_files), '-w', | ||
self.ring_file_name, '-P'] | ||
return params |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can actually just remove this entire method now, the docs in the classdoc should suffice