Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Create single- and double-row symbols #2935

Merged

Conversation

evanshultz
Copy link
Collaborator

@evanshultz evanshultz commented Aug 26, 2020

As promised at #2705 (comment), here are the first batch of DIN 41612 symbols. These cover the single- and double-row footprints we currently have in the library (KiCad/kicad-footprints#1076).

image
image
image

My only real concern is about the footprint filters. It appears CvPcb only looks at the number of pins and not the pin names, which means that a 2x16 connector using pin numbers a1 through a16 and b1 though b16 get matched just like one that has a2-a32 and b2-b32 with only even pins. I don't see a way around that so this may be the best we can do. If not, let me know.

Script PR: KiCad/kicad-library-utils#332

As described in the PR, I wanted to try and get this in since it takes care of most of the footprints we have without requiring any framework changes. That is a bigger process and likely will take more time. So I'd really like to get this in now and do the triple-row symbols in a later PR.

Edit: Related issue and PR:


⚠️ Deprecation warning

In preparation for the KiCad v6 release this repository will be locked down on Sept 1, 2020. No new pull requests will be accepted. Existing pull requests can be worked on until Oct 1, 2020. Changes breaking v5.1 compatibility can be merged starting Sept 1, 2020.

On Oct 1, 2020 this repository, including issues and pull requests, will be archived and transferred to gitlab.com. In order for your pull requests and issues to be imported into GitLab you must set your email address on GitHub to public and use the same address for your GitLab account. Or login to GitLab at least once using the GitHub icon. Otherwise the importer can't correlate the account information and the issues/comments on GitLab will be owned by kicad-bot (importer documentation).

We plan to convert the library to the new v6 S-expr format after it is imported to GitLab. That also means that old pull requests will need to be redone with the v6 format if they are not merged before then.


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • Provide a screenshot of the symbol(s) from the symbol editor with the pin types visible
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Aug 26, 2020
@myfreescalewebpage myfreescalewebpage self-assigned this Sep 5, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Sep 5, 2020
@myfreescalewebpage
Copy link
Collaborator

Hello @evanshultz

One comment about the naming of the symbols: why "DIN41612_02x16_AB" is not called "DIN41612_02x16_AB_OddPins" ?
Else no comment on the symbosl themselves, do you plan to have more parts in this PR ?

Joel

@myfreescalewebpage
Copy link
Collaborator

@evanshultz ping

@evanshultz
Copy link
Collaborator Author

Thee "_EvenPins" versions only have even pin numbers (2, 4, 6...). No suffix means all pin numbers are included (1, 2, 3...). There aren't any symbols with only odd pins because we don't have any footprints with only odd pins. Please check the footprints merged at KiCad/kicad-footprints#1076 or look at them in the library. I do believe that is correct and these symbols will support all single- and dual-row DIN41612 footprints we have in our library.

The script framework needs enhancement to support the triple-row symbols, so I was hoping to stop here and get these merged. Then update the script framework and come back later with another PR for the triple-row symbols. If that's OK with you, then no, I don't plan to add more now.

@myfreescalewebpage
Copy link
Collaborator

@evanshultz thanks for the clarification and for the lesson about naming !
Merging now.

@myfreescalewebpage myfreescalewebpage merged commit 3e0329b into KiCad:master Sep 16, 2020
@evanshultz evanshultz deleted the din41612-single-dual-row branch September 16, 2020 20:12
@evanshultz evanshultz mentioned this pull request Sep 17, 2020
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants