Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Rename STM32L4x1 VDDUSB pin into VDD #2463

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

aurel32
Copy link
Contributor

@aurel32 aurel32 commented Jan 23, 2020

The STM32L4x1 SoCs do not have USB support and thus no VDDUSB pin.
A simple VDD pin is used instead. This probably comes from a copy and
paste issue from other another SoC in the family.


See the change in image for one of the SoCs:
stm32l4x1-vddusb

Link to the datasheet:
https://www.st.com/resource/en/datasheet/stm32l431cb.pdf

The STM32L4x1 SoC do not have USB support and thus no VDDUSB pin.
A simple VDD pin is used instead. This probably comes from a copy and
paste issue from other another SoC in the family.
@myfreescalewebpage myfreescalewebpage added Enhancement Improves existing symbol in the library Pending reviewer A pull request waiting for a reviewer labels Feb 19, 2020
@myfreescalewebpage
Copy link
Collaborator

@aurel32 thanks for pointing this. The modification break existing design and can be merge only for the next major release (V6). I wuld suggest to stack also the VSS pins at the same time. Joel

@myfreescalewebpage myfreescalewebpage self-assigned this Mar 29, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Mar 29, 2020
@myfreescalewebpage myfreescalewebpage added this to the 6.0.0 milestone Mar 29, 2020
@aurel32
Copy link
Contributor Author

aurel32 commented Mar 29, 2020

@aurel32 thanks for pointing this. The modification break existing design and can be merge only for the next major release (V6). I wuld suggest to stack also the VSS pins at the same time. Joel

In the meantime, would that work simply replacing the VDDUSB pin by a VDD one without grouping them? Designs that do not place the "VDDUSB" pin connected to the "VDD" ones are broken anyway.

@myfreescalewebpage
Copy link
Collaborator

If you want yes we can separate in two pull request and first fix the name of the pin only, with no move. This can be merged now without waiting V6.

@evanshultz
Copy link
Collaborator

I believe all of these symbols are auto-generate by a script at https://github.com/KiCad/kicad-library-utils/tree/master/schlib/autogen/stm32. It seems the URL format is changed and I didn't try to track down if this particular symbol is, but fixing the script is the best solution if that is the case. FYI, the script was written by @Ratfink .

@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Mar 31, 2020

Good information from @evanshultz ! If it is, the generator should be updated to generate the symbols again.

@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Sep 21, 2020

We are currently discussing of a new scripting method for all MCU at #3059, the STM generator will no more be up to date if the goal is achieved, I propose to merge the pull request right now for this fix.

@myfreescalewebpage
Copy link
Collaborator

@aurel32 no comment on the VDDUSB pins, just one request if you have time to do it: several symbols have KLC error S5.2 because of wrong fp filter. ST_WLCSP should be ST*WLCSP.

If you have not the time to do it I will merge your PR like that because it's not a regression.

Thanks
Joel

@myfreescalewebpage
Copy link
Collaborator

Not sure the author will respond to the previous question so merging right now.

@myfreescalewebpage myfreescalewebpage merged commit 1b3973f into KiCad:master Sep 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improves existing symbol in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants