Add comment to --inst-debug-printf option #5184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-lunarg
force-pushed
the
i4908
branch
2 times, most recently
from
e7aec0a
to
ea305fe
Compare
This option is only for debugging/fixing debug printf instrumentation. Users who wish to utilize debug printf should see the white paper at vulkan.lunarg.com/doc. Fixes KhronosGroup#4908
s-perron
approved these changes
Apr 2, 2023
Keenuts
requested changes
Apr 3, 2023
s-perron
approved these changes
Apr 3, 2023
s-perron
changed the title
s-perron
reviewed
Apr 3, 2023
| // This option is not for user consumption. It is here to assist in | ||
| // debugging and fixing the debug printf instrumentation pass. For users who | ||
| // wish to utilize debug printf, see the white paper at | ||
| // vulkan.lunarg.com/doc |
There was a problem hiding this comment.
You probably want vulkan.lunarg.com/doc/sdk? Add a ".".
|
Minor fixes for the link, as Nathan pointed out. I trust you to be able to fix it up. I should not have to look at it again. |
|
@spencer-lunarg Is this PR still needed? Only a really small change is needed, and then it could be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4908