Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for NSIS PATH size limitation #778

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

aqnuep
Copy link
Collaborator

@aqnuep aqnuep commented Oct 2, 2023

No description provided.

@aqnuep aqnuep force-pushed the nsis-large-string-support branch 2 times, most recently from f5c4330 to bca1498 Compare October 2, 2023 14:59
@aqnuep aqnuep marked this pull request as ready for review October 2, 2023 16:07
@aqnuep
Copy link
Collaborator Author

aqnuep commented Oct 2, 2023

@MarkCallow, I've verified, using the NSIS version with large string support does fix the installation-time PATH limit issue. Here's the PR to fix it.

The mingw build fails, but there seems to be some general issue with Github CI, it's not related to the changes. Please take a look.

@MarkCallow
Copy link
Collaborator

Terrific. Thanks. Please try adding the following line after line 41 of .github/workflows/mingw.yml

        static: 0

It will prevent the action from trying to remove the now non-existent file. Hopefully whatever other effects it has will not break the build.

@aqnuep
Copy link
Collaborator Author

aqnuep commented Oct 3, 2023

Terrific. Thanks. Please try adding the following line after line 41 of .github/workflows/mingw.yml

        static: 0

It will prevent the action from trying to remove the now non-existent file. Hopefully whatever other effects it has will not break the build.

It seems it just causes other problems down the line.

Is mingw installation actually needed? Other Khronos ecosystem repositories seem to be able to use mingw without any prior setup necessary.

I guess I'll give it a try.

@aqnuep
Copy link
Collaborator Author

aqnuep commented Oct 3, 2023

It seems that this will solve all of our problems with mingw.

@MarkCallow
Copy link
Collaborator

It seems that this will solve all of our problems with mingw.

Thanks. I wasn't aware that the Windows runners had mingw already installed. A contributor set up the MinGW build.

@MarkCallow MarkCallow merged commit 9a1ccbe into KhronosGroup:main Oct 4, 2023
14 checks passed
@aqnuep aqnuep deleted the nsis-large-string-support branch October 12, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants