Skip to content

Commit

Permalink
Add explanatory comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
MarkCallow committed Oct 9, 2024
1 parent cce2b1b commit 0646127
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
7 changes: 6 additions & 1 deletion .github/workflows/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,12 @@ jobs:
with:
python-version: '3.11.4'

# Without this, venv stopped working in 20240929.1 runner.
# virtualenv is no longer included as of 20240929.1 runner so
# install it ourselves. See
# https://github.com/actions/runner-images/issues/10749.
#
# Note that it is the builds of sdist and wheel that require virtualenv
# not the explicit dependencies of pyktx.
- name: Install Python virtualenv
if: matrix.options.py == 'ON' && matrix.check_mkvk != 'ONLY'
run: pip install virtualenv
Expand Down
3 changes: 3 additions & 0 deletions interface/python_binding/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ add_custom_command(
LIBKTX_INCLUDE_DIR=${CMAKE_SOURCE_DIR}/include
LIBKTX_LIB_DIR=${LIBKTX_LIB_DIR}
LIBKTX_VERSION=${KTX_VERSION_NORMALIZED}
# Bulding sdist requires a virtual env. I have not found a
# a way via find_package to ensure venv support is installed.
${PYTHON_EXECUTABLE} -m build --sdist --outdir ${DIST_DIR}
WORKING_DIRECTORY
${SOURCE_DIR}
Expand All @@ -103,6 +105,7 @@ add_custom_command(
LIBKTX_INCLUDE_DIR=${CMAKE_SOURCE_DIR}/include
LIBKTX_LIB_DIR=${LIBKTX_LIB_DIR}
LIBKTX_VERSION=${KTX_VERSION_NORMALIZED}
# Ditto with sdist venv comment.
${PYTHON_EXECUTABLE} -m build --wheel --outdir ${DIST_DIR}
WORKING_DIRECTORY
${SOURCE_DIR}
Expand Down

0 comments on commit 0646127

Please sign in to comment.