Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Python 3.8-compatible string suffix removal idiom #420

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Use Python 3.8-compatible string suffix removal idiom #420

merged 1 commit into from
Oct 29, 2024

Conversation

popescu-v
Copy link
Collaborator

Replace Python >= 3.9 .removeprefix with a Python 3.8-compatible idiom.

@popescu-v popescu-v added this to the v10.2.3 milestone Oct 29, 2024
marcboulle
marcboulle approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@marcboulle marcboulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

On pourrait même laisser le nouveau code tel quel, sans TODO

@popescu-v popescu-v merged commit 42bd4a9 into dev-v10 Oct 29, 2024
64 checks passed
@popescu-v popescu-v deleted the support_py38_in_learningtest_tool branch October 29, 2024 16:17
@popescu-v popescu-v mentioned this pull request Oct 29, 2024
Merged
popescu-v added a commit that referenced this pull request Oct 29, 2024
@popescu-v
Merge pull request #421 from KhiopsML/support_py38_in_learningtest_tool
8d24ee4 
Use Python 3.8-compatible string suffix removal idiom (backport of PR #420 from dev-v10)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcboulle marcboulle marcboulle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v10.2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@popescu-v @marcboulle