feat : 공통컴포넌트 구현 #20
Merged
feat : 공통컴포넌트 구현 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godhyzzang
changed the title
godhyzzang
changed the title
godhyzzang
changed the title
enigsuss
approved these changes
Jul 31, 2024
haejinyun
reviewed
Jul 31, 2024
Comment on lines
+20
to
+22
| fontSize: { | ||
| m: string; | ||
| }; |
There was a problem hiding this comment.
해당 부분에서 폰트 사이즈가 m이란 속성으로 네이밍이 된 이유가 궁금합니다
Container라는 컴포넌트를 사용할때 theme 속성에서 폰트 사이즈를 24px등으로 입력받을 것 같은데 따로 m이라고 하신 이유가 있을까요?
위처럼 작은 요소부터 컴포넌트를 정의하는 방식을 사용해보지 않아서 여쭙니다!
There was a problem hiding this comment.
https://developer.mozilla.org/ko/docs/Web/CSS/font-size
요기 나와있는 것처럼 축약어 느낌으로 사용한건데 곧 올릴 theme파일에 나와있으니 추후에 참고 부탁드려요!
Comment on lines
+18
to
+20
| fontSize: { | ||
| s: string; | ||
| }; |
There was a problem hiding this comment.
얘두 위에 남긴 것이랑 동일한 궁금증입니다!
There was a problem hiding this comment.
https://developer.mozilla.org/ko/docs/Web/CSS/font-size
요기 나와있는 것처럼 축약어 느낌으로 사용한건데 곧 올릴 theme파일에 나와있으니 추후에 참고 부탁드려요!
Yejin0O0
reviewed
Jul 31, 2024
| backgroundColor: string; | ||
| }; | ||
| fontSize: { | ||
| m: string; |
There was a problem hiding this comment.
혹시 이부분 예시 사용 코드를 comment 로 남겨주실 수 있으신가요?
There was a problem hiding this comment.
곧 올릴 theme.tsx파일에 축약어 관련 사항 나와있으니 확인해주세요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #17
1. 공통컴포넌트 구현 과정에서의 Eslint, prettier변경❗️
[문제]
공통컴포넌트.styled.tsx파일을 만들다보니
위 사진처럼 Props=>props.속성 코드를 추가하는 과정에서 eslint no-confusing-arrow 린트에러 발생
[변경]
2. 공통 컴포넌트 구현