Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Input 컴포넌트 search, icon props 추가 #17

Merged
merged 1 commit into from
Sep 24, 2024
Merged

refactor: Input 컴포넌트 search, icon props 추가 #17

merged 1 commit into from
Sep 24, 2024

Conversation

Yejin0O0
Copy link
Collaborator

What is this PR? 🔍

Changes 📝

  • icon이 있는 input을 사용하고 싶은 경우, icon이 있는 컴포넌트를 Input의 icon 속성으로 넘겨주면 됩니다.
  • search input을 사용하고 싶은 경우, Input의 search 속성만 true로 주면 됩니다.

ScreenShot 📷

image image

Precaution

@Yejin0O0 Yejin0O0 self-assigned this Sep 23, 2024
@Yejin0O0 Yejin0O0 added 5PM🌝 오후 5시 전까지 리뷰가 필요합니다. refactor✍️ 그냥 수정 labels Sep 23, 2024
iamgyu
iamgyu approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@iamgyu iamgyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p4: 수정을 통해 search input 따로 분리해 주신 것 감사합니다!

@Yejin0O0 Yejin0O0 merged commit 246762e into develop Sep 24, 2024
1 check passed
@Yejin0O0 Yejin0O0 deleted the 16-refactor-refactor-input-component branch September 24, 2024 01:43
iamgyu pushed a commit that referenced this pull request Oct 14, 2024
@Yejin0O0
refactor: Input 컴포넌트 search, icon props 추가 (#17)
643c538
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamgyu iamgyu iamgyu approved these changes

Assignees

@Yejin0O0 Yejin0O0

Labels
5PM🌝 오후 5시 전까지 리뷰가 필요합니다. refactor✍️ 그냥 수정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[refactor] Refactor Input Component(1H)
2 participants
@Yejin0O0 @iamgyu