New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added artist page, FIXES #361 #362

Merged

KendallDoesCoding merged 7 commits into KendallDoesCoding:main from abhinav2712:main

Sep 29, 2023

Contributor

abhinav2712 commented Mar 24, 2023 •

edited

Loading

🛠️ Fixes Issue

Fixes #361

Related Issue/Addition to code

Adding Artist Page

👨‍💻 Changes proposed

Added an artist page in the nav item
Included 10 artists popular during Christmas
Hover enabled for more info regarding each artists

Type of change

New feature (non-breaking change which adds functionality)
This change requires a documentation update

✔️ Check List (Check all the applicable boxes)

My code follows the code style of this project.
This PR does not contain plagiarized content.
The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

In future, It would be better to make a seperate database for every data present in this website

📷 Screenshots

New Feature:


          added artist page

d862961

abhinav2712 requested a review from KendallDoesCoding as a code owner

March 24, 2023 17:22

pull-request-size bot added the size/L label

netlify bot commented Mar 24, 2023 •

edited

Loading

✅ Deploy Preview for mogulchristmas ready!

Name	Link
🔨 Latest commit	`72283e3`
🔍 Latest deploy log	https://app.netlify.com/sites/mogulchristmas/deploys/6517204b1656920008742f06
😎 Deploy Preview	https://deploy-preview-362--mogulchristmas.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

accesslint bot reviewed

View reviewed changes

accesslint bot left a comment

There are accessibility issues in these changes.

artists/index.html Outdated

+                          <!-- Toggler Outside Menu -->
+                          <div id="header">
+                            <div id="switch">
+                               <label role='switch' class="switch">

accesslint bot Mar 24, 2023

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

artists/index.html Outdated

+                          <div id="header">
+                            <div id="switch">
+                               <label role='switch' class="switch">
+                                 <input class="switch-input" type="checkbox" />

accesslint bot Mar 24, 2023

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

artists/index.html Outdated

+                  <div id='grid-container' class="row">
+                 <div class="flipper">
+                  <div class="front">
+                      <img src="../images/artists-imgs/1.jpg" />

accesslint bot Mar 24, 2023

This image is missing a text alternative. This is a problem for people using screen readers.

artists/index.html Outdated

+                 <div class="flipper">
+                  <div class="front">
+                      <img src="../images/artists-imgs/2.webp" />

accesslint bot Mar 24, 2023

This image is missing a text alternative. This is a problem for people using screen readers.

artists/index.html Outdated

+                 <div class="flipper">
+                  <div class="front">
+                      <img src="../images/artists-imgs/3.webp" />

accesslint bot Mar 24, 2023

This image is missing a text alternative. This is a problem for people using screen readers.

artists/index.html Outdated

+                 <div class="flipper">
+                  <div class="front">
+                      <img src="../images/artists-imgs/8.jpg" />

accesslint bot Mar 24, 2023

This image is missing a text alternative. This is a problem for people using screen readers.

artists/index.html Outdated

+                 <div class="flipper">
+                  <div class="front">
+                      <img src="../images/artists-imgs/9.webp" />

accesslint bot Mar 24, 2023

This image is missing a text alternative. This is a problem for people using screen readers.

artists/index.html Outdated

+                 <div class="flipper">
+                  <div class="front">
+                      <img src="../images/artists-imgs/10.jpg" />

accesslint bot Mar 24, 2023

This image is missing a text alternative. This is a problem for people using screen readers.

artists/index.html Outdated




		<img src="../images/artists-imgs/9.webp" />

accesslint bot Mar 24, 2023

This image is missing a text alternative. This is a problem for people using screen readers.

artists/index.html Outdated



		<img src="../images/artists-imgs/9.webp" />
		<img src="../images/artists-imgs/10.jpg" />

accesslint bot Mar 24, 2023

This image is missing a text alternative. This is a problem for people using screen readers.

KendallDoesCoding requested changes

View reviewed changes

Owner

KendallDoesCoding left a comment

This is amazing. Just need a few changes to get done!

artists/index.html

Owner

KendallDoesCoding Mar 24, 2023

Not mobile responsive:

artists/index.html

Owner

KendallDoesCoding Mar 24, 2023

How will mobile users find info on the artists (They can't hover over right?)

artists/index.html

Owner

KendallDoesCoding Mar 24, 2023

Duplicate of artists on last line:

KendallDoesCoding reviewed

View reviewed changes

artists/index.html

Owner

KendallDoesCoding Mar 24, 2023

The hover sometimes isn't smooth. Please have a look.

KendallDoesCoding reviewed

View reviewed changes

index.html Outdated Show resolved Hide resolved

KendallDoesCoding reviewed

View reviewed changes

index.html

@@ @@ -415,9 +415,13 @@ @@
                     <a href="/you-may-like"
                       >You May Also Like</a
                     >
-                    <a href="/news-articles" target="_blank"
+                    <!-- <a href="/news-articles" target="_blank"

Owner

KendallDoesCoding Mar 24, 2023

Well, don't remove this for now. As I said, I will consider removing this later on. But, this can go below on the nav-bar maybe after Rate Song?

KendallDoesCoding reviewed

View reviewed changes

images/artists-imgs/10.jpg Outdated

Owner

KendallDoesCoding Mar 24, 2023

Can we change Andy William's photo to either:

OR

OR

OR

Pick any one, but I don't like the current one!

Contributor Author

abhinav2712 Mar 24, 2023

4th will do it, I actually was trying to find smaller pic hence was stuck with that..

Owner

KendallDoesCoding commented Mar 25, 2023

@abhinav2712 any update?

Contributor Author

abhinav2712 commented Mar 25, 2023

@abhinav2712 any update?

I may need some more time for this, just got into some other things, but will fix in coming time

Owner

KendallDoesCoding commented Mar 26, 2023 via email

Sure, take your time! *Thanks,* *Kendall Does Coding* *Portfolio <https://cdc-aims.com/click?redirect=https%3A%2F%2Fkendalldoescoding.gq&dID=1679807954569&hashId=060de6478a47358f5315814fdd49f493dff92988d90dca1ba25e30911a8a60f18777e7&linkName=Portfolio>* *Github <https://cdc-aims.com/click?redirect=https%3A%2F%2Fgithub.com%2FKendallDoesCoding&dID=1679807954569&hashId=060de6478a47358f5315814fdd49f493dff92988d90dca1ba25e30911a8a60f18777e7&linkName=Github>* *Youtube* <https://cdc-aims.com/click?redirect=https%3A%2F%2Fkendalldoescoding.gq%2FcodingYT&dID=1679807954569&hashId=060de6478a47358f5315814fdd49f493dff92988d90dca1ba25e30911a8a60f18777e7&linkName=Youtube>

On Sat, 25 Mar 2023 at 20:25, Abhinav Kumar ***@***.***> wrote: @abhinav2712 <https://github.com/abhinav2712> any update? I may need some more time for this, just got into some other things, but will fix in coming time — Reply to this email directly, view it on GitHub <#362 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUGJUTPOT3TUYWJAZVJV73DW54BPJANCNFSM6AAAAAAWG2UGM4> . You are receiving this because your review was requested.Message ID: ***@***.***>

Owner

KendallDoesCoding commented Apr 1, 2023

@abhinav2712 - any update?

Owner

KendallDoesCoding commented Apr 9, 2023

@abhinav2712 - any update or should I close the PR?

abhinav2712 closed this

Owner

KendallDoesCoding commented Apr 9, 2023

@abhinav2712 why?

Contributor Author

abhinav2712 commented Apr 10, 2023

@KendallDoesCoding Man, Have a lot of other commitments, didnt want to hold this PR, you can do one thing to add this in issue s FEAT REQUEST, or shall I do it?

Owner

KendallDoesCoding commented Apr 10, 2023

@KendallDoesCoding Man, Have a lot of other commitments, didnt want to hold this PR, you can do one thing to add this in issue s FEAT REQUEST, or shall I do it?

I'll reopen PR but I or someone else will work on it. I don't want to stress you out.

KendallDoesCoding reopened this

KendallDoesCoding self-assigned this

KendallDoesCoding mentioned this pull request

[FEATURE REQUEST] - Adding "Artist" nav item on nav bar #361

Closed

KendallDoesCoding added 4 commits

September 30, 2023 00:22


          Update index.html

eb130c4


          Remove the duplicates.

28eb70e


          update

e4776fb


          Update index.html

a950571

accesslint bot reviewed

View reviewed changes

accesslint bot left a comment

👏 You fixed the issue(s)! Great work.

KendallDoesCoding added 2 commits

September 30, 2023 00:36


          Update styles.css


          Update index.html

72283e3

KendallDoesCoding reviewed

View reviewed changes

Owner

KendallDoesCoding left a comment

LGTM ✔️.

This works for now, but we'll make it slightly more responsive in the future.

KendallDoesCoding merged commit 30a0aa0 into KendallDoesCoding:main

7 of 10 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels