Skip to content

Commit

Permalink
Removed NamedEntity
Browse files Browse the repository at this point in the history
  • Loading branch information
fprochazka committed Aug 12, 2013
1 parent 61e4738 commit 9dd60db
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 44 deletions.
1 change: 1 addition & 0 deletions src/Kdyby/Doctrine/Entities/IdentifiedEntity.php
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ abstract class IdentifiedEntity extends BaseEntity
*/
final public function getId()
{
/** @deprecated remove me with orm stable 2.4 */

This comment has been minimized.

Copy link
@Majkl578

Majkl578 Aug 12, 2013

Member

How is it changed in 2.4?

This comment has been minimized.

Copy link
@fprochazka

fprochazka Aug 12, 2013

Author Member

The proxy in 2.4 always has it's identifier, so having final method without the magic if should be enough.

This comment has been minimized.

Copy link
@Majkl578

Majkl578 Aug 12, 2013

Member

Cool. :) Though that can't be considered BC break, since it's Doctrine's internals.

This comment has been minimized.

Copy link
@fprochazka

fprochazka Aug 12, 2013

Author Member

Well, it was for me :P

if ($this instanceof Proxy && !$this->__isInitialized__ && !$this->id) {
$identifier = $this->getReflection()->getProperty('_identifier');
$identifier->setAccessible(TRUE);
Expand Down
44 changes: 0 additions & 44 deletions src/Kdyby/Doctrine/Entities/NamedEntity.php

This file was deleted.

0 comments on commit 9dd60db

Please sign in to comment.