WIP

.github/actions/cache_go/action.yml

@@ -0,0 +1,12 @@
+name: Cache Go
+description: Cache Go imports and modules
+runs:
+  using: composite
+  steps:
+    - name: Cache Go
+      uses: actions/cache@v4
+      with:
+        key: gomod-k-${{ hashFiles('**/go.mod', '**/go.sum') }}
+        path: |
+          /go/bin/goimports
+          /go/pkg/mod

.github/actions/changed_files/action.yml

@@ -0,0 +1,11 @@
+name: Changed Files
+description: Get changed files
+runs:
+  using: composite
+  steps:
+    - name: Get changed files
+      id: changed-files
+      uses: tj-actions/changed-files@v42
+      with:
+        files: |
+          **/*.go

.github/actions/setup_go/action.yml

@@ -0,0 +1,32 @@
+name: Setup Go
+description: Install Go
+runs:
+  using: composite
+  steps:
+    - name: Install Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: ${{ env.GO_VERSION }}
+        go-version-file: go.mod
+        cache-dependency-path: go.sum
+        cache: true
+    - name: Set Cache Path
+      id: paths
+      run: |
+        echo "GOBUILD_PATH=$(go env GOCACHE)" >> "$GITHUB_OUTPUT"
+        echo "GOMOD_PATH=$(go env GOMODCACHE)" >> "$GITHUB_OUTPUT"
+      shell: bash
+    - name: Go Build Cache
+      uses: actions/cache@v4
+      with:
+        path: ${{ steps.paths.outputs.GOBUILD_PATH }}
+        key: ${{ runner.os }}-go-build-${{ hashFiles('**/go.sum') }}
+    - name: Go Mod Cache
+      uses: actions/cache@v4
+      with:
+        path: ${{ steps.paths.outputs.GOMOD_PATH }}
+        key: ${{ runner.os }}-go-build-${{ hashFiles('**/go.mod') }}
+    - name: Run go mod download
+      run: |
+        go mod download
+      shell: bash

.github/workflows/ci-lint.yml

@@ -1,17 +1,44 @@
 name: Lint Checks
 on:
   workflow_call:
+
+permissions:
+  # Optional: allow write access to checks to allow the action to annotate code in the PR.
+  checks: write
+
 # run per commit ci checks against this commit
 jobs:
   proto-lint:
     uses: ./.github/workflows/proto.yml
   golangci-lint:
     runs-on: ubuntu-latest
+    permissions:
+      contents: read  # to download code coverage results from unit_tests job
+      pull-requests: write # write permission needed to comment on PR
+      checks: write
     steps:
-      - uses: actions/checkout@v4
+      - name: Checkout code
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - name: Load Version
+        id: load-version
+        run: |
+          echo "GOLANGCI_VERSION=v$(cat .golangci-version)"
       - name: golangci-lint
-        uses: reviewdog/action-golangci-lint@v2
+        uses: golangci/golangci-lint-action@v6
+        with:
+          version: ${{ steps.load-version.outputs.GOLANGCI_VERSION }}
+          args: --timeout 30m --verbose --allow-parallel-runners --max-same-issues 0 --max-issues-per-linter 0
+          working-directory: ${{ github.workspace }}
+  golang-sec:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: '0'
+      - name: Run Gosec Security Scanner
+        uses: cosmos/gosec@master
         with:
-          github_token: ${{ secrets.github_token }}
-          reporter: github-pr-review
-          golangci_lint_flags: --timeout 10m
+          args: ./...

.github/workflows/go.yml

@@ -0,0 +1,88 @@
+name: Golang CI
+#
+#on:
+#  merge_group:
+#  pull_request:
+#    branches:
+#      - '*'
+#env:
+#  GO_VERSION: '1.21'
+#
+#jobs:
+#  changed_files:
+#    name: Changed Files
+#    runs-on: ubutnu-latest
+#    outputs:
+#      changed_files: ${{ steps.changed_files.outputs.all_changed_files }}
+#    steps:
+#      - name: Checkout
+#        uses: actions/checkout@v4
+#      - name: Changed Files
+#        id: changed_files
+#        uses: ./.github/actions/changed_files
+#
+#  golang-ci:
+#    needs:
+#      - changed_files
+#    if: |
+#      contains(needs.changed_files.outputs.changed_files, '.go')
+#    name: golangci-lint
+#    runs-on:
+#      labels: 16-cores
+#    steps:
+#      - name: Checkout
+#        uses: actions/checkout@v4
+#      - name: Setup
+#        uses: ./.github/actions/setup_go
+#        with:
+#          cache: false
+#      - name: Load Version
+#        id: load-version
+#        run: |
+#          echo "GOLANGCI_VERSION=v$(cat .golangci-version)"
+#      - name: golangci-ling
+#        uses: golangci/golangci-lint-action@v6
+#        with:
+#          version: $${{ steps.load-version.outputs.GOLANGCI_VERSION }}
+#          args: --timeout 30m --verbose --allow-parallel-runners --max-same-issues 0 --max-issues-per-linter 0
+#          working-directory: ${{ github.workspace }}
+#
+#  golang-test:
+#    needs:
+#      - changed_files
+#    if: |
+#      contains(needs.changed_files.outputs.changed_files, '.go') ||
+#      contains(needs.changed_files.outputs.changed_files, 'go.sum') ||
+#      (
+#        contains(needs.changed_files.outputs.changed_files, '.yml') ||
+#        contains(needs.changed_files.outputs.changed_files, '.yaml')
+#      )
+#      &&
+#      (
+#        contains(needs.changed_files.outputs.changed_files, 'app') ||
+#        contains(needs.changed_files.outputs.changed_files, 'client') ||
+#        contains(needs.changed_files.outputs.changed_files, 'cmd') ||
+#        contains(needs.changed_files.outputs.changed_files, 'migrate') ||
+#        contains(needs.changed_files.outputs.changed_files, 'tests') ||
+#        contains(needs.changed_files.outputs.changed_files, 'x')
+#      )
+#    name: go test
+#    runs-on:
+#      labels: 16-cores
+#    env:
+#      COVERAGE_DIR: out/coverage/unit/go
+#      COVERAGE_PATH: out/coverage/unit/go/cover.out
+#      FORMATTED_REPORT: out/coverage/unit/go/go-unit-cover.out
+#      HTML_REPORT: out/coverage/unit/go/go-unit-cover.html
+#    steps:
+#      - name: Checkout
+#        uses: actions/checkout@v4
+#      - name: Setup
+#        uses: ./.github/actions/setup_go
+#      - name: Go Test
+#        run: |
+#          mkdir -p ${{ env.COVERAGE_DIR }}
+#          readarray -t test_dirs < <(find * -name "*_test.go" -exec dirname {} \; | sort | uniq | grep -v -e '^\.$')
+#          half_nproc=$(( $(nproc --all) / 2 ))
+#          printf '%s\0' "${test_dirs[@]}" | xargs -0 -P $half_nproc -n 1 -I {} go test "./{}" -race
+#

.github/workflows/proto.yml

@@ -3,6 +3,9 @@ name: Protobuf Checks
 on:
   workflow_call:
 
+# fix this too
+
+
 jobs:
   check-proto:
     name: "Check Proto"

.golangci-version

@@ -0,0 +1 @@
+v1.59

Makefile

@@ -314,6 +314,11 @@ test-ibc: docker-build
 test:
 	@$(GO_BIN) test $$($(GO_BIN) list ./... | grep -v 'contrib' | grep -v 'tests/e2e')
 
+coverage:
+	@mkdir -p out
+	@$(GO_BIN) test -v -coverprofile=out/coverage.out  $$($(GO_BIN) list ./... | grep -v 'contrib' | grep -v 'tests/e2e')
+	@$(GO_BIN) tool cover -html="out/coverage.out"
+
 # Run cli integration tests
 # `-p 4` to use 4 cores, `-tags cli_test` to tell $(GO_BIN) not to ignore the cli package
 # These tests use the `kvd` or `kvcli` binaries in the build dir, or in `$BUILDDIR` if that env var is set.

app/app.go

@@ -1016,6 +1016,7 @@ func NewApp(
 	app.mm.RegisterInvariants(&app.crisisKeeper)
 
 	app.configurator = module.NewConfigurator(app.appCodec, app.MsgServiceRouter(), app.GRPCQueryRouter())
+
 	app.RegisterServices(app.configurator)
 
 	// RegisterUpgradeHandlers is used for registering any on-chain upgrades.

app/genesis.go

@@ -10,5 +10,6 @@ type GenesisState map[string]json.RawMessage
 // NewDefaultGenesisState generates the default state for the application.
 func NewDefaultGenesisState() GenesisState {
 	encCfg := MakeEncodingConfig()
+
 	return ModuleBasics.DefaultGenesis(encCfg.Marshaler)
 }

cmd/kava/cmd/rocksdb/compact.go

@@ -32,6 +32,7 @@ var allowedDBs = []string{"application", "blockstore", "state"}
 
 func CompactRocksDBCmd() *cobra.Command {
 	cmd := &cobra.Command{
+
 		Use: fmt.Sprintf(
 			"compact <%s>",
 			strings.Join(allowedDBs, "|"),

x/bep3/client/cli/query.go

@@ -44,13 +44,11 @@ func GetQueryCmd(queryRoute string) *cobra.Command {
 		QueryGetAtomicSwapsCmd(queryRoute),
 		QueryParamsCmd(queryRoute),
 	}
-
 	for _, cmd := range cmds {
 		flags.AddQueryFlagsToCmd(cmd)
 	}
 
 	bep3QueryCmd.AddCommand(cmds...)
-
 	return bep3QueryCmd
 }
 

x/bep3/genesis.go

@@ -24,6 +24,7 @@ func InitGenesis(ctx sdk.Context, keeper keeper.Keeper, accountKeeper types.Acco
 		if perm == authtypes.Burner {
 			hasBurnPermissions = true
 		}
+
 		if perm == authtypes.Minter {
 			hasMintPermissions = true
 		}