Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unregister x/metrics & call BeginBlocker directly #1689

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

pirtleshell
Copy link
Member

registering x/metrics to the module manager breaks the AppHash because its consensus version is added to the ModuleVersionMap which affects the AppHash.

this commit unregisters the module so it is not consensus breaking. instead, it directly calls the BeginBlock before running the module manager's.

(backport of #1686)

registering x/metrics to the module manager breaks the AppHash because
its consensus version is added to the ModuleVersionMap which affects the
AppHash.

this commit unregisters the module so it is not consensus breaking.
instead, it directly calls the BeginBlock before running the module
manager's.
@pirtleshell pirtleshell merged commit 6e7926b into release/v0.21.x Aug 28, 2023
3 checks passed
@pirtleshell pirtleshell deleted the rp-v21-fix-metrics-app-hash branch August 28, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant