Injecting enabled precompiles list to EVM #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drklee3
reviewed
Apr 24, 2024
There was a problem hiding this comment.
We likely don't need the Manager at all anymore if we pass in a slice of enabledContracts -- added some suggestions to make it more clear on what I mean
Should be more simple and keeps handling of whether or not a precompile is enabled within parent caller in x/evm
evgeniy-scherbina
force-pushed
the
precompile-manager
branch
3 times, most recently
from
d8624b6
to
4b58de3
Compare
drklee3
reviewed
Apr 25, 2024
evgeniy-scherbina
changed the title
evgeniy-scherbina
force-pushed
the
precompile-manager
branch
from
4b58de3
to
4dbf483
Compare
evgeniy-scherbina
added a commit
that referenced
this pull request
May 13, 2024
Injecting enabled precompiles list to EVM (backport #27)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related document: https://kava-labs.atlassian.net/wiki/spaces/ENG/pages/1464598529/Precompile+Registry+Design