Fixes #37988 - migrate container repo naming to use slashes #11208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Changes the default container naming scheme to use slashes instead of dashes.
Considerations taken when implementing this change?
We don't want the change to happen for existing repositories. To do this, we rely on the fact that the
::Katello::Repository
model holds the container repository name, which gets changed on updates as a before_validation hook. When updating repositories in the UI, that changes the root, not the repository. So, there is no way for the container repository to be update just by updating things on the UI.However, the naming scheme will change for content view publishes and promotions, since the environment repository gets updated.
Is this behavior okay? Should new content views with old repositories continue to use the old naming default? In a way, when publishing/promoting, it's like creating new repositories. If we need to keep the old default, it may complicate the logic a bit.
Plus, we want users to use this new naming scheme because it is better and more readable. If users don't like the new scheme, it's easy to go back to the old default by adding a custom registry naming scheme.
What are the testing steps for this pull request?