Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Katello 4.13 only: Fixes #37896 - Make toasts for host details REX jobs work again #11177

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

nadjaheitmann
Copy link
Contributor

@nadjaheitmann nadjaheitmann commented Oct 9, 2024

What are the changes introduced in this pull request?

Based on this discussion: #10962 (comment)
Fixes this:
image

What are the testing steps for this pull request?

Go to host details page
Start anything that triggers a REX job, e.g. "Refresh applicability"

CC @jeremylenz @MariaAga

@nadjaheitmann nadjaheitmann changed the title Fixes #37896 - Make toasts for host detail REX job work again Fixes #37896 - Make toasts for host details REX jobs work again Oct 9, 2024
@nadjaheitmann nadjaheitmann changed the title Fixes #37896 - Make toasts for host details REX jobs work again Katello 4.13 only: Fixes #37896 - Make toasts for host details REX jobs work again Oct 9, 2024
@nadjaheitmann
Copy link
Contributor Author

@jeremylenz Do you mind taking a quick look at this?

Copy link
Member

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

test failures unrelated, our testing is broken on 4.13 branch.
Lint passed so that's good enough for me

@jeremylenz jeremylenz merged commit 8f6f959 into Katello:KATELLO-4.13 Oct 21, 2024
5 of 21 checks passed
@nadjaheitmann nadjaheitmann deleted the 37896 branch October 21, 2024 15:04
@nadjaheitmann
Copy link
Contributor Author

Thanks!

@jeremylenz
Copy link
Member

@parthaa this is ready to cherry-pick to 4.13 now :)

@nadjaheitmann
Copy link
Contributor Author

@jeremylenz You just merged it to 4.13 stable branch 🤔

@jeremylenz
Copy link
Member

Good point 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants