Fixes #37820 - If a smart proxy sync task fails in plan, we don't report it in sync status

[sjha4]

What are the changes introduced in this pull request?

By default, plan phase and finalize phase in actions are wrapped in a single transaction. Any error in these phases rolls back all DB changes during the phase.
One of those changes is a link record to the task that links the resource (smart proxy in this action) and the task so we can query the tasks back using for_resource helper like here:

katello/app/models/katello/concerns/smart_proxy_extensions.rb

Line 460 in 746bda7

def last_failed_sync_tasks

The issue is when the action fails during the plan phase the link record is deleted as part of the transaction rollback.

Considerations taken when implementing this change?

We can turn the transaction middleware off for an action. Doing this for smart proxy sync means that any DB changes made during a failed plan/finalize phase will persist.
Looking at the capsule sync task, the only DB op we do in finalize is around audit records. We should be able to live without having it wrapped in a transaction.

What are the testing steps for this pull request?

1. Have a server and proxy.
2. Sync.
3. Turn the proxy off and start a proxy sync.
4. It will fail.
5. Refresh page and you'll not see the failed task being reported.
6. With this PR it ill show last task as failed.
7. Try the same with some error in run phase. Use fail "random error" in any planned action's run phase to mimic this for example.
8. Failed task should still show up in proxy details page.

[sjha4]

@adamruzicka 👀 :FYI:

[chris1984]

Works fine for me and code looks fine. @adamruzicka any objections?

[adamruzicka]

any objections?

While I'm not exactly happy about us having to do this, we don't really have any other sensible option, so yeah, let's go with this