Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #37587 - Reuse API parameter handling from base #11126

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fixes #37587 - Reuse API parameter handling from base #11126

wants to merge 2 commits into from

Commits on Aug 30, 2024

  1. Refs #37587 - Remove unused sort_params method 

    This method has been unused since ElasticSearch was dropped.

Fixes: 26cbfb4 ("Refs #11753 - remove elastic search from content view filter rules")
    @ekohl
    ekohl committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    29392cf View commit details
    Browse the repository at this point in the history

  2. Fixes #37587 - Reuse API parameter handling from base 

    Foreman's API base controller provides a search_and_pagination parameter
group that has all the fields needed. Then it also provides some helpers
to parse these values properly.

This reuses those helpers. It also aligns on per_page=all handling
instead of a separate full_result=true. That parameter is now
deprecated.
    @ekohl
    ekohl committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    f1815eb View commit details
    Browse the repository at this point in the history