Fix Style Cops #11067
Merged
Fix Style Cops #11067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archanaserver
force-pushed
the
fix-style-cops
branch
2 times, most recently
from
28a3c8c
to
04401be
Compare
qcjames53
approved these changes
Jul 17, 2024
archanaserver
force-pushed
the
fix-style-cops
branch
from
04401be
to
0046c56
Compare
@qcjames53 i just rebased it! |
|
@archanaserver looks like we need another rebase because I merged a bunch of your PRs :) |
This pull request addresses the Style/RedundantRegexpEscape RuboCop offense by removing unnecessary escapes in the regular expression pattern.
Disabled several Style cops which may cause failure after applying changes also some are unsafe to do so for huge number of offenses fix. Also followed other foreman rubocop rules.
archanaserver
force-pushed
the
fix-style-cops
branch
from
0046c56
to
0c613d4
Compare
thanks @ianballou , and rebased it again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
#11009
This pull request addresses several style issues in the codebase and updates the .rubocop.yml configuration file to better manage RuboCop offenses.
Considerations taken when implementing this change?
Check commits for details
What are the testing steps for this pull request?
bundle exec rubocop