Fix Style/CaseLikeIf cop #11047
Merged
Fix Style/CaseLikeIf cop #11047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-bucher
approved these changes
Jul 3, 2024
Comment on lines
139
to
140
| name = name.downcase | ||
| if name =~ /red\s*hat/ | ||
| case name |
There was a problem hiding this comment.
We could simplify this to case name.downcase now.
There was a problem hiding this comment.
Good catch. Thanks
There was a problem hiding this comment.
@m-bucher i've updated the changes, can you take a look?
I've used --autocorrect flag to fix this cop
archanaserver
force-pushed
the
fix-style/caselikeif
branch
from
ab52b46
to
d614ebd
Compare
ianballou
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Based on #11009
Addresses the Style/CaseLikeIf rule by converting if-elsif statements to case-when statements
Considerations taken when implementing this change?
Ensured that all if-elsif statements were appropriately converted to case-when.
Make sure of existing logic and functionality of the code during the conversion.
What are the testing steps for this pull request?
We can run the test to ensure that no functionality is broken and all tests pass.