Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37099 - Update repo fixture URL to Pulp hosted for tests #10917

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chris1984
Copy link
Member

@chris1984 chris1984 commented Mar 7, 2024

What are the changes introduced in this pull request?

Considerations taken when implementing this change?

  • N/A

What are the testing steps for this pull request?

  • Make sure tests pass

@ianballou
Copy link
Member

Looks like some of the code will need to be modified due to changes in the repository. Here's the output of trying to rerecord the multi copy all units test:

[vagrant@centos8-katello-devel katello]$ mode=all ktest test/actions/pulp3/orchestration/multi_copy_all_units_test.rb
WARNING: File locale/en_GB/LC_MESSAGES/foreman_virt_who_configure.mo outdated, regenerate with 'make all-mo'
WARNING: File locale/pt_BR/LC_MESSAGES/foreman_virt_who_configure.mo outdated, regenerate with 'make all-mo'
WARNING: File locale/en_GB/LC_MESSAGES/foreman_virt_who_configure.mo outdated, regenerate with 'make all-mo'
WARNING: File locale/pt_BR/LC_MESSAGES/foreman_virt_who_configure.mo outdated, regenerate with 'make all-mo'
/home/vagrant/foreman/.vendor/ruby/2.7.0/gems/activerecord-6.1.7.7/lib/active_record/connection_adapters/postgresql_adapter.rb:883: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/home/vagrant/foreman/.vendor/ruby/2.7.0/gems/pg-1.5.6/lib/pg/text_decoder/timestamp.rb:8: warning: The called method `initialize' is defined here
Emptying /home/vagrant/foreman/jenkins/reports/unit
-- execute("SET CONSTRAINTS ALL DEFERRED;")
WARNING:  SET CONSTRAINTS can only be used in transaction blocks
   -> 0.0006s

# Running tests with run options --seed 39696:

.........F.FFFFFFFFFF........Writing XML reports to /home/vagrant/foreman/jenkins/reports/unit


Finished tests in 234.320817s, 0.1238 tests/s, 0.3884 assertions/s.


Failure:
Actions::Pulp3::MultiCopyAllUnitYumRepositoryTest#test_yum_copy_with_whitelist_max_version_filter [/home/vagrant/katello/test/actions/pulp3/orchestration/multi_copy_all_units_test.rb:209]
Minitest::Assertion: --- expected
+++ actual
@@ -1 +1 @@
-["walrus-0.71-1.noarch.rpm"]
+["zebra-0.1-2.noarch.rpm", "wolf-9.4-2.noarch.rpm", "walrus-5.21-1.noarch.rpm", "walrus-0.71-1.noarch.rpm", "tiger-1.0-4.noarch.rpm", "stork-0.12-2.noarch.rpm", "squirrel-0.1-1.noarch.rpm", "penguin-0.9.1-1.noarch.rpm", "mouse-0.1.12-1.noarch.rpm", "lion-0.4-1.noarch.rpm", "kangaroo-0.3-1.noarch.rpm", "kangaroo-0.2-1.noarch.rpm", "horse-0.22-2.noarch.rpm", "gorilla-0.62-1.noarch.rpm", "giraffe-0.67-2.noarch.rpm", "frog-0.1-1.noarch.rpm", "fox-1.1-2.noarch.rpm", "elephant-8.3-1.noarch.rpm", "duck-0.8-1.noarch.rpm", "duck-0.7-1.noarch.rpm", "duck-0.6-1.noarch.rpm", "dolphin-3.10.232-1.noarch.rpm", "dog-4.23-1.noarch.rpm", "cow-2.2-3.noarch.rpm", "cockateel-3.1-1.noarch.rpm", "chimpanzee-0.21-1.noarch.rpm", "cheetah-1.25.3-5.noarch.rpm", "cat-1.0-1.noarch.rpm", "camel-0.1-1.noarch.rpm", "bear-4.1-1.noarch.rpm"]


Failure:
Actions::Pulp3::MultiCopyAllUnitYumRepositoryTest#test_yum_copy_all_no_filter_rules_without_dependency_solving [/home/vagrant/katello/test/actions/pulp3/orchestration/multi_copy_all_units_test.rb:101]
Minitest::Assertion: --- expected
+++ actual
@@ -1 +1 @@
-["trout-0.12-1.noarch.rpm"]
+["zebra-0.1-2.noarch.rpm", "wolf-9.4-2.noarch.rpm", "walrus-5.21-1.noarch.rpm", "walrus-0.71-1.noarch.rpm", "trout-0.12-1.noarch.rpm", "tiger-1.0-4.noarch.rpm", "stork-0.12-2.noarch.rpm", "squirrel-0.1-1.noarch.rpm", "penguin-0.9.1-1.noarch.rpm", "mouse-0.1.12-1.noarch.rpm", "lion-0.4-1.noarch.rpm", "kangaroo-0.3-1.noarch.rpm", "kangaroo-0.2-1.noarch.rpm", "horse-0.22-2.noarch.rpm", "gorilla-0.62-1.noarch.rpm", "giraffe-0.67-2.noarch.rpm", "frog-0.1-1.noarch.rpm", "fox-1.1-2.noarch.rpm", "elephant-8.3-1.noarch.rpm", "duck-0.8-1.noarch.rpm", "duck-0.7-1.noarch.rpm", "duck-0.6-1.noarch.rpm", "dolphin-3.10.232-1.noarch.rpm", "dog-4.23-1.noarch.rpm", "cow-2.2-3.noarch.rpm", "cockateel-3.1-1.noarch.rpm", "chimpanzee-0.21-1.noarch.rpm", "cheetah-1.25.3-5.noarch.rpm", "cat-1.0-1.noarch.rpm", "camel-0.1-1.noarch.rpm", "bear-4.1-1.noarch.rpm"]


Failure:
Actions::Pulp3::MultiCopyAllUnitYumRepositoryTest#test_yum_copy_with_whitelist_min_version_filter [/home/vagrant/katello/test/actions/pulp3/orchestration/multi_copy_all_units_test.rb:192]
Minitest::Assertion: --- expected
+++ actual
@@ -1 +1 @@
-["walrus-5.21-1.noarch.rpm"]
+["zebra-0.1-2.noarch.rpm", "wolf-9.4-2.noarch.rpm", "walrus-5.21-1.noarch.rpm", "walrus-0.71-1.noarch.rpm", "tiger-1.0-4.noarch.rpm", "stork-0.12-2.noarch.rpm", "squirrel-0.1-1.noarch.rpm", "penguin-0.9.1-1.noarch.rpm", "mouse-0.1.12-1.noarch.rpm", "lion-0.4-1.noarch.rpm", "kangaroo-0.3-1.noarch.rpm", "kangaroo-0.2-1.noarch.rpm", "horse-0.22-2.noarch.rpm", "gorilla-0.62-1.noarch.rpm", "giraffe-0.67-2.noarch.rpm", "frog-0.1-1.noarch.rpm", "fox-1.1-2.noarch.rpm", "elephant-8.3-1.noarch.rpm", "duck-0.8-1.noarch.rpm", "duck-0.7-1.noarch.rpm", "duck-0.6-1.noarch.rpm", "dolphin-3.10.232-1.noarch.rpm", "dog-4.23-1.noarch.rpm", "cow-2.2-3.noarch.rpm", "cockateel-3.1-1.noarch.rpm", "chimpanzee-0.21-1.noarch.rpm", "cheetah-1.25.3-5.noarch.rpm", "cat-1.0-1.noarch.rpm", "camel-0.1-1.noarch.rpm", "bear-4.1-1.noarch.rpm"]


Failure:
Actions::Pulp3::MultiCopyAllUnitYumRepositoryTest#test_yum_copy_with_errata_exclusion_filter [/home/vagrant/katello/test/actions/pulp3/orchestration/multi_copy_all_units_test.rb:64]
Minitest::Assertion: Expected ["zebra", "wolf", "walrus", "walrus", "trout", "tiger", "stork", "squirrel", "shark", "pike", "penguin", "mouse", "lion", "kangaroo", "kangaroo", "horse", "gorilla", "giraffe", "frog", "fox", "elephant", "duck", "duck", "dolphin", "dog", "cow", "cockateel", "chimpanzee", "cheetah", "cat", "camel", "bear"] to not include "duck".

Failure:
Actions::Pulp3::MultiCopyAllUnitYumRepositoryTest#test_yum_copy_with_duplicate_content [/home/vagrant/katello/test/actions/pulp3/orchestration/multi_copy_all_units_test.rb:215]
Minitest::Assertion: Expected: 32
  Actual: 34

Failure:
Actions::Pulp3::MultiCopyAllUnitYumRepositoryTest#test_yum_copy_nonmatching_package_includion_filter_copies_no_content [/home/vagrant/katello/test/actions/pulp3/orchestration/multi_copy_all_units_test.rb:119]
Minitest::Assertion: Expected #<ActiveRecord::Associations::CollectionProxy [#<Katello::Rpm id: 1046166395, pulp_id: "/pulp/api/v3/content/rpm/packages/018dc861-b834-79...", created_at: "2024-03-08 17:34:32.024214000 +0000", updated_at: "2024-03-08 17:34:32.024216000 +0000", name: "cow", version: "2.2", release: "3", arch: "noarch", epoch: "0", filename: "cow-2.2-3.noarch.rpm", sourcerpm: "cow-2.2-3.src.rpm", checksum: "a4bb63892ccb294ec002423007eb0538a32f84f2613fa7f6b5...", version_sortable: "01-2.01-2", release_sortable: "01-3", summary: "A dummy package of cow", nvra: "cow-2.2-3.noarch", modular: false, migrated_pulp3_href: nil, evr: "(0,\"{\"\"(2,)\"\",\"\"(2,)\"\"}\",\"{\"\"(3,)\"\"}\")">, #<Katello::Rpm id: 1046166368, pulp_id: "/pulp/api/v3/content/rpm/packages/018dc861-b86c-73...", created_at: "2024-03-08 17:34:32.024071000 +0000", updated_at: "2024-03-08 17:34:32.024093000 +0000", name: "zebra", version: "0.1", release: "2", arch: "noarch", epoch: "0", filename: "zebra-0.1-2.noarch.rpm", sourcerpm: "zebra-0.1-2.src.rpm", checksum: "7aa66335d8ebc295d626abc0639135ff6dec6333d4e94e0da6...", version_sortable: "01-0.01-1", release_sortable: "01-2", summary: "A dummy package of zebra", nvra: "zebra-0.1-2.noarch", modular: false, migrated_pulp3_href: nil, evr: "(0,\"{\"\"(0,)\"\",\"\"(1,)\"\"}\",\"{\"\"(2,)\"\"}\")">, #<Katello::Rpm id: 1046166369, pulp_id: "/pulp/api/v3/content/rpm/packages/018dc861-b86a-7c...", created_at: "2024-03-08 17:34:32.024096000 +0000", updated_at: "2024-03-08 17:34:32.024099000 +0000", name: "wolf", version: "9.4", release: "2", arch: "noarch", epoch: "0", filename: "wolf-9.4-2.noarch.rpm", sourcerpm: "wolf-9.4-2.src.rpm", checksum: "a42b42020d3f3eefc4421d89ce341a7b9f9293c1b4bdea33bb...", version_sortable: "01-9.01-4", release_sortable: "01-2", summary: "A dummy package of wolf", nvra: "wolf-9.4-2.noarch", modular: false, migrated_pulp3_href: nil, evr: "(0,\"{\"\"(9,)\"\",\"\"(4,)\"\"}\",\"{\"\"(2,)\"\"}\")">, #<Katello::Rpm id: 1046166370, pulp_id: "/pulp/api/v3/content/rpm/packages/018dc861-b866-7a...", created_at: "2024-03-08 17:34:32.024101000 +0000", updated_at: "2024-03-08 17:34:32.024103000 +0000", name: "walrus", version: "5.21", release: "1", arch: "noarch", epoch: "0", filename: "walrus-5.21-1.noarch.rpm", sourcerpm: "walrus-5.21-1.src.rpm", checksum: "74533fbd4f9ada9e02a6361cbbf014b8ff88dff8d69785ec48...", version_sortable: "01-5.02-21", release_sortable: "01-1", summary: "A dummy package of walrus", nvra: "walrus-5.21-1.noarch", modular: true, migrated_pulp3_href: nil, evr: "(0,\"{\"\"(5,)\"\",\"\"(21,)\"\"}\",\"{\"\"(1,)\"\"}\")">, #<Katello::Rpm id: 1046166371, pulp_id: "/pulp/api/v3/content/rpm/packages/018dc861-b864-74...", created_at: "2024-03-08 17:34:32.024106000 +0000", updated_at: "2024-03-08 17:34:32.024108000 +0000", name: "walrus", version: "0.71", release: "1", arch: "noarch", epoch: "0", filename: "walrus-0.71-1.noarch.rpm", sourcerpm: "walrus-0.71-1.src.rpm", checksum: "516a22ccc0cbe3ecb2cbee1c626a39b91767dbf0f815afda7b...", version_sortable: "01-0.02-71", release_sortable: "01-1", summary: "A dummy package of walrus", nvra: "walrus-0.71-1.noarch", modular: true, migrated_pulp3_href: nil, evr: "(0,\"{\"\"(0,)\"\",\"\"(71,)\"\"}\",\"{\"\"(1,)\"\"}\")">, #<Katello::Rpm id: 1046166372, pulp_id: "/pulp/api/v3/content/rpm/packages/018dc861-b862-7b...", created_at: "2024-03-08 17:34:32.024110000 +0000", updated_at: "2024-03-08 17:34:32.024112000 +0000", name: "trout", version: "0.12", release: "1", arch: "noarch", epoch: "0", filename: "trout-0.12-1.noarch.rpm", sourcerpm: "trout-0.12-1.src.rpm", checksum: "1024a6a1e466e1b57eaee3df88ed6e6c285c6393c74fb5c1ac...", version_sortable: "01-0.02-12", release_sortable: "01-1", summary: "A dummy package of trout", nvra: "trout-0.12-1.noarch", modular: false, migrated_pulp3_href: nil, evr: "(0,\"{\"\"(0,)\"\",\"\"(12,)\"\"}\",\"{\"\"(1,)\"\"}\")">, #<Katello::Rpm id: 1046166373, pulp_id: "/pulp/api/v3/content/rpm/packages/018dc861-b860-75...", created_at: "2024-03-08 17:34:32.024114000 +0000", updated_at: "2024-03-08 17:34:32.024117000 +0000", name: "tiger", version: "1.0", release: "4", arch: "noarch", epoch: "0", filename: "tiger-1.0-4.noarch.rpm", sourcerpm: "tiger-1.0-4.src.rpm", checksum: "61724e3ebd4ff93943d75b504ba78fe2854acdc753e7e7ce4e...", version_sortable: "01-1.01-0", release_sortable: "01-4", summary: "A dummy package of tiger", nvra: "tiger-1.0-4.noarch", modular: false, migrated_pulp3_href: nil, evr: "(0,\"{\"\"(1,)\"\",\"\"(0,)\"\"}\",\"{\"\"(4,)\"\"}\")">, #<Katello::Rpm id: 1046166374, pulp_id: "/pulp/api/v3/content/rpm/packages/018dc861-b85e-7d...", created_at: "2024-03-08 17:34:32.024119000 +0000", updated_at: "2024-03-08 17:34:32.024121000 +0000", name: "stork", version: "0.12", release: "2", arch: "noarch", epoch: "0", filename: "stork-0.12-2.noarch.rpm", sourcerpm: "stork-0.12-2.src.rpm", checksum: "002634703c8a5e467603f208fa2ac7062715c03bbc46846776...", version_sortable: "01-0.02-12", release_sortable: "01-2", summary: "A dummy package of stork", nvra: "stork-0.12-2.noarch", modular: false, migrated_pulp3_href: nil, evr: "(0,\"{\"\"(0,)\"\",\"\"(12,)\"\"}\",\"{\"\"(2,)\"\"}\")">, #<Katello::Rpm id: 1046166375, pulp_id: "/pulp/api/v3/content/rpm/packages/018dc861-b85c-76...", created_at: "2024-03-08 17:34:32.024123000 +0000", updated_at: "2024-03-08 17:34:32.024125000 +0000", name: "squirrel", version: "0.1", release: "1", arch: "noarch", epoch: "0", filename: "squirrel-0.1-1.noarch.rpm", sourcerpm: "squirrel-0.1-1.src.rpm", checksum: "fb23d97b733a2cdf084c6cf1ea79ce8081d0c5332f3d08b560...", version_sortable: "01-0.01-1", release_sortable: "01-1", summary: "A dummy package of squirrel", nvra: "squirrel-0.1-1.noarch", modular: false, migrated_pulp3_href: nil, evr: "(0,\"{\"\"(0,)\"\",\"\"(1,)\"\"}\",\"{\"\"(1,)\"\"}\")">, #<Katello::Rpm id: 1046166377, pulp_id: "/pulp/api/v3/content/rpm/packages/018dc861-b858-77...", created_at: "2024-03-08 17:34:32.024132000 +0000", updated_at: "2024-03-08 17:34:32.024134000 +0000", name: "pike", version: "2.2", release: "1", arch: "noarch", epoch: "0", filename: "pike-2.2-1.noarch.rpm", sourcerpm: "pike-2.2-1.src.rpm", checksum: "35632daef8124ef8f20bc216f5ca029e048de36a243a62bb1d...", version_sortable: "01-2.01-2", release_sortable: "01-1", summary: "A dummy package of pike", nvra: "pike-2.2-1.noarch", modular: false, migrated_pulp3_href: nil, evr: "(0,\"{\"\"(2,)\"\",\"\"(2,)\"\"}\",\"{\"\"(1,)\"\"}\")">, ...]> to be empty.

Failure:
Actions::Pulp3::MultiCopyAllUnitYumRepositoryTest#test_yum_copy_nonmatching_package_exclusion_filter_copies_everything [/home/vagrant/katello/test/actions/pulp3/orchestration/multi_copy_all_units_test.rb:137]
Minitest::Assertion: Expected: 32
  Actual: 34

Failure:
Actions::Pulp3::MultiCopyAllUnitYumRepositoryTest#test_yum_copy_with_whitelist_name_filter [/home/vagrant/katello/test/actions/pulp3/orchestration/multi_copy_all_units_test.rb:175]
Minitest::Assertion: --- expected
+++ actual
@@ -1 +1 @@
-["kangaroo"]
+["zebra", "wolf", "walrus", "walrus", "tiger", "stork", "squirrel", "penguin", "mouse", "lion", "kangaroo", "kangaroo", "horse", "gorilla", "giraffe", "frog", "fox", "elephant", "duck", "duck", "duck", "dolphin", "dog", "cow", "cockateel", "chimpanzee", "cheetah", "cat", "camel", "bear"]


Failure:
Actions::Pulp3::MultiCopyAllUnitYumRepositoryTest#test_yum_copy_with_errata_inclusion_filter [/home/vagrant/katello/test/actions/pulp3/orchestration/multi_copy_all_units_test.rb:82]
Minitest::Assertion: --- expected
+++ actual
@@ -1 +1 @@
-["crow", "duck", "stork"]
+["cockateel", "crow", "duck", "penguin", "stork"]


Failure:
Actions::Pulp3::MultiCopyAllUnitYumRepositoryTest#test_yum_copy_with_all_duplicate_content_with_dep_solving [/home/vagrant/katello/test/actions/pulp3/orchestration/multi_copy_all_units_test.rb:272]
Minitest::Assertion: --- expected
+++ actual
@@ -1 +1 @@
-["shark-0.1-1.noarch.rpm", "stork-0.12-2.noarch.rpm", "walrus-0.71-1.noarch.rpm", "whale-0.2-1.noarch.rpm"]
+["bear-4.1-1.noarch.rpm", "camel-0.1-1.noarch.rpm", "cat-1.0-1.noarch.rpm", "cheetah-1.25.3-5.noarch.rpm", "chimpanzee-0.21-1.noarch.rpm", "cockateel-3.1-1.noarch.rpm", "cow-2.2-3.noarch.rpm", "crow-0.8-1.noarch.rpm", "dog-4.23-1.noarch.rpm", "dolphin-3.10.232-1.noarch.rpm", "duck-0.6-1.noarch.rpm", "duck-0.7-1.noarch.rpm", "duck-0.8-1.noarch.rpm", "elephant-8.3-1.noarch.rpm", "fox-1.1-2.noarch.rpm", "frog-0.1-1.noarch.rpm", "giraffe-0.67-2.noarch.rpm", "gorilla-0.62-1.noarch.rpm", "horse-0.22-2.noarch.rpm", "kangaroo-0.2-1.noarch.rpm", "kangaroo-0.3-1.noarch.rpm", "lion-0.4-1.noarch.rpm", "mouse-0.1.12-1.noarch.rpm", "penguin-0.9.1-1.noarch.rpm", "pike-2.2-1.noarch.rpm", "squirrel-0.1-1.noarch.rpm", "stork-0.12-2.noarch.rpm", "tiger-1.0-4.noarch.rpm", "trout-0.12-1.noarch.rpm", "walrus-0.71-1.noarch.rpm", "walrus-5.21-1.noarch.rpm", "wolf-9.4-2.noarch.rpm", "zebra-0.1-2.noarch.rpm"]


Failure:
Actions::Pulp3::MultiCopyAllUnitYumRepositoryTest#test_yum_copy_all_no_filter_rules_with_dependency_solving [/home/vagrant/katello/test/actions/pulp3/orchestration/multi_copy_all_units_test.rb:156]
Minitest::Assertion: --- expected
+++ actual
@@ -1 +1 @@
-["bear", "cat", "crow", "dolphin", "elephant", "gorilla", "horse", "kangaroo", "lion", "mouse", "penguin", "pike", "tiger", "trout", "wolf", "zebra"]
+["bear", "camel", "cat", "cheetah", "chimpanzee", "cockateel", "cow", "crow", "dog", "dolphin", "duck", "duck", "duck", "elephant", "fox", "frog", "giraffe", "gorilla", "horse", "kangaroo", "kangaroo", "lion", "mouse", "penguin", "pike", "squirrel", "stork", "tiger", "trout", "walrus", "walrus", "wolf", "zebra"]


29 tests, 91 assertions, 11 failures, 0 errors, 0 skips

Minitest Reporters: Mean Time Report (Samples: 11, Order: :avg :desc)
Avg: 97.233729332 Min: 97.233729332 Max: 97.233729332 Last: 97.233729332 Description: Actions::Pulp3::MultiCopyAllUnitYumRepositoryTest
Avg: 32.085983377 Min: 32.085983377 Max: 32.085983377 Last: 32.085983377 Description: Actions::Pulp3::MultiCopyAllUnitYumErrataRepositoryTest
Avg: 31.673775603 Min: 31.673775603 Max: 31.673775603 Last: 31.673775603 Description: Actions::Pulp3::MultiCopyAllUnitYumModuleStreamRepositoryTest
Avg: 24.485432945 Min: 24.485432945 Max: 24.485432945 Last: 24.485432945 Description: Actions::Pulp3::MultiCopyAllUnitYumPackageGroupsRepositoryTest
Avg: 22.884121678 Min: 2.097387694  Max: 109.306350065 Last: 8.970900437  Description: Actions::Pulp3::AlternateContentSourceRefreshTest
Avg: 15.756752208 Min: 15.756752208 Max: 15.756752208 Last: 15.756752208 Description: Actions::Pulp3::MultiCopyAllUnitYumPackageEnvironmentRepositoryTest
Avg: 15.709380461 Min: 15.709380461 Max: 15.709380461 Last: 15.709380461 Description: Actions::Pulp3::MultiCopyAllUnitYumDistributionTreesRepositoryTest
Avg: 9.199384289  Min: 9.199384289  Max: 9.199384289  Last: 9.199384289  Description: Actions::Pulp3::MultiCopyAllUnitYumModlemdDefaultsRepositoryTest
Avg: 8.174431386  Min: 8.174431386  Max: 8.174431386  Last: 8.174431386  Description: Actions::Pulp3::MultiCopyAllUnitYumSrpmsRepositoryTest
Avg: 6.572985174  Min: 2.546455042  Max: 10.599515305 Last: 10.599515305 Description: Actions::Katello::ContentViewVersion::ExportTest
Avg: 2.383713872  Min: 2.383713872  Max: 2.383713872  Last: 2.383713872  Description: Katello::RepositorySearchTest
Avg: 2.320402922  Min: 1.68027338   Max: 2.960532464  Last: 2.960532464  Description: Katello::SmartProxyExtensionsTest
Avg: 1.598871487  Min: 1.25495308   Max: 1.942789895  Last: 1.25495308   Description: Katello::RepositoryInstanceTest
Avg: 1.254679195  Min: 0.5818127    Max: 1.92754569   Last: 0.5818127    Description: Katello::SmartProxyPulp3Test
Avg: 1.187957326  Min: 1.187957326  Max: 1.187957326  Last: 1.187957326  Description: Katello::RepositoryCreateTest

@ianballou
Copy link
Member

ianballou commented Mar 8, 2024

I tested the repo with some RPM inclusion filters and found out that the package groups are still coming along for a ride for some reason. However it seems like test_yum_copy_with_whitelist_max_version_filter might be failing for another reason since there are even more RPMs than there should be... need to investigate more via debugger.

@ianballou
Copy link
Member

ianballou commented Mar 8, 2024

I might've found the issue:

[14] pry(#<Katello::Pulp3::Repository::Yum>)> ::Katello::Repository.find(source_repo_ids.first).rpms.where(:modular => true).count
=> 8
[16] pry(#<Katello::Pulp3::Repository::Yum>)> ::Katello::Repository.find(source_repo_ids.first).module_streams.count
=> 0

The repository has modular RPMs but no module streams? That's gonna cause some bugs.

Edit: this was caused by my Pulp having synced a modular version of the repo at some point.

@ianballou
Copy link
Member

Oh also the repo in the description is different from https://fixtures.pulpproject.org/rpm-unsigned-modified/ that's in the code -- did you mean to use https://fixtures.pulpproject.org/rpm-advisory-diffpkgs/ ?

@chris1984
Copy link
Member Author

Member

I used that one at first but then switched to one Grant suggested. I will update the PR description

@ianballou
Copy link
Member

ianballou commented Mar 8, 2024

Found the problem with Actions::Pulp3::MultiCopyAllUnitYumRepositoryTest#test_yum_copy_with_whitelist_max_version_filter :

What we request Pulp to copy (notice that it's one RPM (walrus) and one package group (mammals):

=> #<PulpRpmClient::Copy:0x000055bdb3882ab8
 @config=
  [{:source_repo_version=>"/pulp/api/v3/repositories/rpm/rpm/018e1f5e-2a4b-76ca-aabd-5a35c11e699d/versions/1/",
    :dest_repo=>"/pulp/api/v3/repositories/rpm/rpm/018e1f5e-2dfa-783f-ba09-49fae6276b7f/",
    :content=>
     ["/pulp/api/v3/content/rpm/packagegroups/018e1f5a-6fa1-78bd-8a4b-deb569c5d8a4/",
      "/pulp/api/v3/content/rpm/packages/018e1f5a-6f95-71e1-9481-f133deb3b249/"]}],
 @dependency_solving=false>

Dest repo contents empty since: ""latest_version_href": "/pulp/api/v3/repositories/rpm/rpm/018e1f5e-2dfa-783f-ba09-49fae6276b7f/versions/0/""

[vagrant@centos8-katello-devel foreman]$ pulp show --href /pulp/api/v3/repositories/rpm/rpm/018e1f5e-2dfa-783f-ba09-49fae6276b7f/versions/1/
{
  "pulp_href": "/pulp/api/v3/repositories/rpm/rpm/018e1f5e-2dfa-783f-ba09-49fae6276b7f/versions/1/",
  "pulp_created": "2024-03-08T18:46:30.855853Z",
  "number": 1,
  "repository": "/pulp/api/v3/repositories/rpm/rpm/018e1f5e-2dfa-783f-ba09-49fae6276b7f/",
  "base_version": null,
  "content_summary": {
    "added": {
      "rpm.package": {
        "count": 21,
        "href": "/pulp/api/v3/content/rpm/packages/?repository_version_added=/pulp/api/v3/repositories/rpm/rpm/018e1f5e-2dfa-783f-ba09-49fae6276b7f/versions/1/"
      },
      "rpm.packagegroup": {
        "count": 1,
        "href": "/pulp/api/v3/content/rpm/packagegroups/?repository_version_added=/pulp/api/v3/repositories/rpm/rpm/018e1f5e-2dfa-783f-ba09-49fae6276b7f/versions/1/"
      }
    },
    "removed": {},
    "present": {
      "rpm.package": {
        "count": 21,
        "href": "/pulp/api/v3/content/rpm/packages/?repository_version=/pulp/api/v3/repositories/rpm/rpm/018e1f5e-2dfa-783f-ba09-49fae6276b7f/versions/1/"
      },
      "rpm.packagegroup": {
        "count": 1,
        "href": "/pulp/api/v3/content/rpm/packagegroups/?repository_version=/pulp/api/v3/repositories/rpm/rpm/018e1f5e-2dfa-783f-ba09-49fae6276b7f/versions/1/"
      }
    }
  }
}

Issue: We include a package group if at least one RPM exists in the repo that belongs to the group. Thus, we copy in the "mammals" package group, which has many RPMs:

[vagrant@centos8-katello-devel foreman]$ pulp show --href /pulp/api/v3/content/rpm/packagegroups/?repository_version_added=/pulp/api/v3/repositories/rpm/rpm/018e1f5e-2dfa-783f-ba09-49fae6276b7f/versions/1/
{
  "count": 1,
  "next": null,
  "previous": null,
  "results": [
    {
      "pulp_href": "/pulp/api/v3/content/rpm/packagegroups/018e1f5a-6fa1-78bd-8a4b-deb569c5d8a4/",
      "pulp_created": "2024-03-08T18:36:44.973585Z",
      "id": "mammals",
      "default": true,
      "user_visible": true,
      "display_order": 1024,
      "name": "mammals",
      "description": "",
      "packages": [
        {
          "name": "bear",
          "type": 3,
          "requires": null,
          "basearchonly": null
        },
        {
          "name": "camel",
          "type": 3,
          "requires": null,
          "basearchonly": null
        },
        {
          "name": "cat",
          "type": 3,
          "requires": null,
          "basearchonly": null
        },
        {
          "name": "cheetah",
          "type": 3,
          "requires": null,
          "basearchonly": null
        },
        {
          "name": "chimpanzee",
          "type": 3,
          "requires": null,
          "basearchonly": null
        },
        {
          "name": "cow",
          "type": 3,
          "requires": null,
          "basearchonly": null
        },
        {
          "name": "dog",
          "type": 3,
          "requires": null,
          "basearchonly": null
        },
        {
          "name": "dolphin",
          "type": 3,
          "requires": null,
          "basearchonly": null
        },
        {
          "name": "elephant",
          "type": 3,
          "requires": null,
          "basearchonly": null
        },
        {
          "name": "fox",
          "type": 3,
          "requires": null,
          "basearchonly": null
        },
        {
          "name": "giraffe",
          "type": 3,
          "requires": null,
          "basearchonly": null
        },
        {
          "name": "gorilla",
          "type": 3,
          "requires": null,
          "basearchonly": null
        },
        {
          "name": "horse",
          "type": 3,
          "requires": null,
          "basearchonly": null
        },
        {
          "name": "kangaroo",
          "type": 3,
          "requires": null,
          "basearchonly": null
        },
        {
          "name": "lion",
          "type": 3,
          "requires": null,
          "basearchonly": null
        },
        {
          "name": "mouse",
          "type": 3,
          "requires": null,
          "basearchonly": null
        },
        {
          "name": "squirrel",
          "type": 3,
          "requires": null,
          "basearchonly": null
        },
        {
          "name": "tiger",
          "type": 3,
          "requires": null,
          "basearchonly": null
        },
        {
          "name": "walrus",
          "type": 3,
          "requires": null,
          "basearchonly": null
        },
        {
          "name": "whale",
          "type": 3,
          "requires": null,
          "basearchonly": null
        },
        {
          "name": "wolf",
          "type": 3,
          "requires": null,
          "basearchonly": null
        },
        {
          "name": "zebra",
          "type": 3,
          "requires": null,
          "basearchonly": null
        }
      ],
      "biarch_only": false,
      "desc_by_lang": {},
      "name_by_lang": {},
      "digest": "30d5eb14fd3e0f02bb2de97c6db0c6665fbc15ace70967260708cfaa28280e41"
    }
  ]
}

We either need to fix the tests to account for this, or find a new repository in the Pulp fixtures that doesn't have any package groups.

@chris1984
Copy link
Member Author

@sjha4 updated the unit tests from your pastebin except the one I talked to you about in slack, lets see how this looks.

@sjha4
Copy link
Member

sjha4 commented Apr 23, 2024

[test katello]

@ianballou
Copy link
Member

there are still some VCR errors on here.

@chris1984
Copy link
Member Author

Yeah I got to get back to this one eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants