Fixes #36748 - fix usage of deb copy api #10734
Conversation
|
Issues: #36748 |
m-bucher
force-pushed
the
fix_copy_deb_api_usage
branch
3 times, most recently
from
5e29f59
to
c52d713
Compare
m-bucher
force-pushed
the
fix_copy_deb_api_usage
branch
from
c52d713
to
139e4b9
Compare
m-bucher
force-pushed
the
fix_copy_deb_api_usage
branch
from
139e4b9
to
96ec110
Compare
m-bucher
force-pushed
the
fix_copy_deb_api_usage
branch
from
96ec110
to
eaaf3dd
Compare
m-bucher
force-pushed
the
fix_copy_deb_api_usage
branch
from
eaaf3dd
to
c48b175
Compare
|
[test katello] |
| @@ -203,9 +212,9 @@ def add_debs(source_repo_ids, filters, filter_list_map) | |||
| filter_list_map | |||
| end | |||
|
|
|||
| def copy_content_from_mapping(repo_id_map, options = {}) | |||
| def copy_content_from_mapping(repo_id_map, _options = {}) | |||
There was a problem hiding this comment.
I don't think copy_content_from_mapping will even run for Debian content, so these methods can likely be taken out entirely. If you trace back references to copy_content_from_mapping, you'll eventually get here:
That shows that we only do the whole "multi copy" workflow for yum content anyway.
This wasn't always the case, but it has been since Katello 4.3.
There was a problem hiding this comment.
Although, if dep solving is something that is a TODO for debian content, then I'd recommend keeping these methods of course.
There was a problem hiding this comment.
I believe we will need it eventually for the IncrementalUpdate to work : #10847
Dependency Solving for debian is currently out-of-scope and due to various reasons like lacking support for efficient handling (sorting and comparing) of debian version within PostgreSQL.
This is also the reason I added a PR to make sure dep-solving with debs is never even tried 😈 : #10734
Pulp-Deb does not support dependency-solving.
Also we should use the correct name of the copy-api class.