Fixes #36708 - Repair module stream details page breadcrumb bar #10713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qcjames53
force-pushed
the
36708-module-stream-hyperlink
branch
from
cd90652
to
374d5e1
Compare
qcjames53
force-pushed
the
36708-module-stream-hyperlink
branch
from
374d5e1
to
704b0f8
Compare
qcjames53
force-pushed
the
36708-module-stream-hyperlink
branch
from
704b0f8
to
8d96dc5
Compare
jeremylenz
changed the title
jeremylenz
changed the title
jeremylenz
reviewed
Sep 1, 2023
There was a problem hiding this comment.
Code LGTM and works as advertised! One small request - can you please change the commit message to present tense? (I've edited the PR title accordingly)
If you look at past pull requests, present tense seems to be the convention. Also, this way, it will match the "Fixes" enforced by pr-processor.
Thanks!
Adding updated testing snapshots and reverting accidentally modified tests.
qcjames53
force-pushed
the
36708-module-stream-hyperlink
branch
from
8d96dc5
to
70dcee3
Compare
Done! Thank you for reviewing. |
jeremylenz
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
The breadcrumb bar at the top of the module stream details page now has a properly-rendering hyperlink.
Considerations taken when implementing this change?
n/a
What are the testing steps for this pull request?