Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #36538 - Don't delete manifests referenced by tags or manifest lists #10711

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Fixes #36538 - Don't delete manifests referenced by tags or manifest lists #10711

merged 1 commit into from
Sep 12, 2023

Conversation

sjha4
Copy link
Member

@sjha4 sjha4 commented Aug 28, 2023

What are the changes introduced in this pull request?

Ignore manifests during deletion that are referenced by docker tags or manifest lists

Considerations taken when implementing this change?

What are the testing steps for this pull request?

  1. Sync a docker repo.
  2. Go to repository > manifest list.
  3. Select a few from the list and try deleting.
  4. Deletion should ignore any manifests with tags associated. (ex: quay/busybox should ignore the only manifest and also fail saying "No docker manifests to delete after ignoring manifests with tags or manifest lists")
  5. If your docker repo has more than one valid manifest selected, that doesn't contain tags or lists, the removal will continue and ignore manifests with tags or lists.

@theforeman-bot
Copy link

Issues: #36538

@chris1984 chris1984 self-assigned this Sep 7, 2023
chris1984
chris1984 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, works great.

@sjha4 sjha4 merged commit cfc586c into Katello:master Sep 12, 2023
5 checks passed
chris1984 pushed a commit that referenced this pull request Oct 3, 2023
@sjha4 @damoore044
Fixes #36538 - Don't delete manifests referenced by tags or manifest …
cb9a2dc 
…lists (#10711)

(cherry picked from commit cfc586c)
chris1984 pushed a commit that referenced this pull request Oct 4, 2023
@sjha4 @chris1984
Fixes #36538 - Don't delete manifests referenced by tags or manifest …
966af69 
…lists (#10711)

(cherry picked from commit cfc586c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris1984 chris1984 chris1984 approved these changes

Assignees

@chris1984 chris1984

Labels
Ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjha4 @theforeman-bot @chris1984