Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #36695 - remove docker_tags_whitelist #10708

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Fixes #36695 - remove docker_tags_whitelist #10708

merged 1 commit into from
Sep 5, 2023

Conversation

ianballou
Copy link
Member

What are the changes introduced in this pull request?

Removes remaining traces of docker_tags_whitelist

Considerations taken when implementing this change?

Should only be backported to 4.10. 4.9 and below need this attribute to work.

What are the testing steps for this pull request?

  1. Ensure that docker_tags_whitelist cannot be updated on a repository
  2. Ensure updating include_tags and exclude_tags on a container repo still work.

@theforeman-bot
Copy link

Issues: #36695

sjha4
sjha4 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@sjha4 sjha4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Ack 👍🏼

@ianballou ianballou merged commit 2292c98 into Katello:master Sep 5, 2023
4 of 5 checks passed
@ianballou ianballou deleted the 36695-remove-docker-tags-whitelist branch September 5, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjha4 sjha4 sjha4 approved these changes

Assignees
No one assigned
Labels
Not yet reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ianballou @theforeman-bot @sjha4